After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707039 - Remove manual initialization of videoinfo in gst_v4l2_object_get_caps_info()
Remove manual initialization of videoinfo in gst_v4l2_object_get_caps_info()
Status: RESOLVED DUPLICATE of bug 703399
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.0.10
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-29 11:11 UTC by Paul HENRYS
Modified: 2013-08-30 10:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (7.22 KB, patch)
2013-08-29 11:11 UTC, Paul HENRYS 		rejected Details | Review

Description Paul HENRYS 2013-08-29 11:11:44 UTC 
Created attachment 253485 [details] [review]
Patch

In gst_v4l2_object_get_caps_info() of gstv4l2object.c, videoinfo is initialized with gst_video_info_from_caps() only for video/x-raw. This leads to have a video format set to GST_VIDEO_FORMAT_UNKNOWN whereas it should be set to GST_VIDEO_FORMAT_ENCODED for compressed videos.
This also means that the condition "stride != obj->bytesperline" in gst_v4l2_buffer_pool_set_config() of gstv4l2bufferpool.c will be checked and this might failed as some drivers output something different than 0 (as explained in commit log 1ed4239ea7ce2f5eda5a8f7029a718f42f06c155).

See the patch provided as a possible solution.
Comment 1 Sebastian Dröge (slomo) 2013-08-30 09:33:30 UTC 
Thanks for taking the time to report this bug.
This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade.

*** This bug has been marked as a duplicate of bug 703399 ***
Comment 2 Paul HENRYS 2013-08-30 10:04:57 UTC 
I was looking for one reporting it but didn't find it :)
Good to know it's fixed. Thx.