After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707015 - flacenc: Sends buffers before caps are set and breaks FLAC-in-Ogg
flacenc: Sends buffers before caps are set and breaks FLAC-in-Ogg
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.0.8
Other Linux
: Normal normal
: 1.0.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-28 20:56 UTC by Marcin Lewandowski
Modified: 2013-08-29 09:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Original WAV (86.18 KB, audio/x-wav)
2013-08-28 20:56 UTC, Marcin Lewandowski
Details
Ogg/FLAC encoded with 0.10 (26.71 KB, video/ogg)
2013-08-28 20:57 UTC, Marcin Lewandowski
Details
Ogg/FLAC encoded with 1.0 (156 bytes, video/ogg)
2013-08-28 20:57 UTC, Marcin Lewandowski
Details
FLAC (no container) encoded with 1.0 (26.46 KB, audio/flac)
2013-08-28 20:57 UTC, Marcin Lewandowski
Details

Description Marcin Lewandowski 2013-08-28 20:56:28 UTC
Seems that I've found regression in 1.0.

I've created 1s mono sine in audacity. I've tried to encode it with 0.10 and 1.0:

gst-launch-0.10 filesrc location=sine.wav ! decodebin ! audioconvert ! flacenc ! oggmux ! filesink location=sine-flac-encoded-with-0.10.ogg

gst-launch-1.0 filesrc location=sine.wav ! decodebin ! audioconvert ! flacenc ! oggmux ! filesink location=sine-flac-encoded-with-1.0.ogg

marcin@marcin:~/bug$ ls -l
razem 120
-rw-rw-r-- 1 marcin marcin 27346 sie 28 22:51 sine-flac-encoded-with-0.10.ogg
-rw-rw-r-- 1 marcin marcin   156 sie 28 22:51 sine-flac-encoded-with-1.0.ogg
-rw-rw-r-- 1 marcin marcin 88244 sie 28 22:50 sine.wav

Obviously file encoded with 1.0 does not play.

When I create pure FLAC file, it is OK

gst-launch-1.0 filesrc location=sine.wav ! decodebin ! audioconvert ! flacenc ! filesink location=sine-flac-encoded-with-1.0.flac

marcin@marcin:~/bug$ ls -l
razem 148
-rw-rw-r-- 1 marcin marcin 27346 sie 28 22:51 sine-flac-encoded-with-0.10.ogg
-rw-rw-r-- 1 marcin marcin 27094 sie 28 22:54 sine-flac-encoded-with-1.0.flac
-rw-rw-r-- 1 marcin marcin   156 sie 28 22:51 sine-flac-encoded-with-1.0.ogg
-rw-rw-r-- 1 marcin marcin 88244 sie 28 22:50 sine.wav
Comment 1 Marcin Lewandowski 2013-08-28 20:56:57 UTC
Created attachment 253444 [details]
Original WAV
Comment 2 Marcin Lewandowski 2013-08-28 20:57:17 UTC
Created attachment 253445 [details]
Ogg/FLAC encoded with 0.10
Comment 3 Marcin Lewandowski 2013-08-28 20:57:32 UTC
Created attachment 253446 [details]
Ogg/FLAC encoded with 1.0
Comment 4 Marcin Lewandowski 2013-08-28 20:57:50 UTC
Created attachment 253447 [details]
FLAC (no container) encoded with 1.0
Comment 5 Marcin Lewandowski 2013-08-28 21:05:11 UTC
This is most probably related to Bug 707016.
Comment 6 Sebastian Dröge (slomo) 2013-08-29 09:18:40 UTC
Works fine in 1.1.4, fails in 1.0.10.
Comment 7 Sebastian Dröge (slomo) 2013-08-29 09:27:18 UTC
This commit in 1.1.4 fixed it, backported to 1.0 and will be in 1.0.11 release.

commit de7e1cb6dd8e5031b1d1d9a64fdda955bae54501
Author: Sebastian Dröge <slomo@circular-chaos.org>
Date:   Fri Aug 16 13:26:28 2013 +0200

    flacenc: Properly set headers via the base class instead of just pushing them downstream
    
    Prevents buffers from being send before the caps and segment events.