After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707007 - Building optimization-guide fails
Building optimization-guide fails
Status: RESOLVED FIXED
Product: gnome-devel-docs
Classification: Applications
Component: optimization-guide
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-devel-docs maintainers
gnome-devel-docs maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-28 17:17 UTC by Jiro Matsuzawa
Modified: 2013-09-22 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
optimization-guide: Update Makefile.am for mallard (1022 bytes, patch)
2013-08-28 17:30 UTC, Jiro Matsuzawa
committed Details | Review

Description Jiro Matsuzawa 2013-08-28 17:17:50 UTC
Here is a error log:
% make
Making all in accessibility-devel-guide
make[1]: Entering directory `/opt/gnome/checkout/gnome-devel-docs/accessibility-devel-guide'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/opt/gnome/checkout/gnome-devel-docs/accessibility-devel-guide'
Making all in platform-demos
make[1]: Entering directory `/opt/gnome/checkout/gnome-devel-docs/platform-demos'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/opt/gnome/checkout/gnome-devel-docs/platform-demos'
Making all in hig
make[1]: Entering directory `/opt/gnome/checkout/gnome-devel-docs/hig'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/opt/gnome/checkout/gnome-devel-docs/hig'
Making all in integration-guide
make[1]: Entering directory `/opt/gnome/checkout/gnome-devel-docs/integration-guide'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/opt/gnome/checkout/gnome-devel-docs/integration-guide'
Making all in optimization-guide
make[1]: Entering directory `/opt/gnome/checkout/gnome-devel-docs/optimization-guide'
make[1]: *** No rule to make target `C/index.docbook', needed by `all'.  Stop.
make[1]: Leaving directory `/opt/gnome/checkout/gnome-devel-docs/optimization-guide'
make: *** [all-recursive] Error 1
Comment 1 Jiro Matsuzawa 2013-08-28 17:30:03 UTC
Created attachment 253421 [details] [review]
optimization-guide: Update Makefile.am for mallard

Could you please review it?
Comment 2 Kerrick Staley 2013-08-31 18:50:44 UTC
This fixes the build, but there are still many references to the files

index.docbook
optimization-harmful.xml
optimization-massif.xml
optimization-intro.xml

in the various .po files.

Note: the first broken commit was 9ba0d959 "optimization-guide: Conversion from DocBook to Mallard".
Comment 3 Jiro Matsuzawa 2013-09-01 07:27:38 UTC
Thank you for the review.

(In reply to comment #2)
> This fixes the build, but there are still many references to the files
> 
> index.docbook
> optimization-harmful.xml
> optimization-massif.xml
> optimization-intro.xml
> 
> in the various .po files.
> 
Do you mean the location information, the lines starting with "#:", in the po files by "many references"? For example, the following "C/index.docbook:5(book/title)" is a location information:
% sed -n '26,28p' optimization-guide/cs/cs.po
#: C/index.docbook:5(book/title)
msgid "Optimizing GNOME Software"
msgstr "Optimalizace softwaru GNOME"

They are no problem.


> Note: the first broken commit was 9ba0d959 "optimization-guide: Conversion from
> DocBook to Mallard".

Yes, I know that. We could revert it to fix this error.
Comment 4 Jiro Matsuzawa 2013-09-20 01:51:37 UTC
This conversion is incomplete. For example, index.page still has a lot of docbook elements. We could revert the commit for 3.10.0. That does not have any effect on translation. There have been no translation updates since the commit.
Comment 5 Christian Kirbach 2013-09-22 09:47:14 UTC
The fact remains: the build is broken and we are about to release 3.10  o_O

Making all in optimization-guide
make[1]: Entering directory `/space/git/gnome/gnome-devel-docs/optimization-guide'
make[1]: *** No rule to make target `C/index.docbook', needed by `all'.  Stop.
Comment 6 David King 2013-09-22 18:37:11 UTC
Comment on attachment 253421 [details] [review]
optimization-guide: Update Makefile.am for mallard

Thanks, I pushed a slightly-modified commit to master as commit fd21e9cb6371d4a761e790d11167a7a73d8b9062.
Comment 7 David King 2013-09-22 18:37:42 UTC
I fixed the remaining Mallard conversion bits in commit dbaa29e766b801c66df389ed4267dc45cf01265f.