After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706988 - Port to GtkListBox
Port to GtkListBox
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-28 14:53 UTC by Guillaume Desmottes
Modified: 2013-09-05 07:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
depends on Gtk+ 3.9.4 (1.08 KB, patch)
2013-09-04 14:31 UTC, Guillaume Desmottes 		committed Details | Review
roster-contact: inherit from GtkListBoxRow (2.76 KB, patch)
2013-09-04 14:31 UTC, Guillaume Desmottes 		committed Details | Review
roster-group: inherit from GtkListBoxRow (3.78 KB, patch)
2013-09-04 14:31 UTC, Guillaume Desmottes 		committed Details | Review
roster-view: inherit from GtkListBox (17.07 KB, patch)
2013-09-04 14:31 UTC, Guillaume Desmottes 		committed Details | Review
remove egg-list-box (3.31 KB, patch)
2013-09-04 14:31 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2013-08-28 14:53:10 UTC 
We should use https://developer.gnome.org/gtk3/unstable/GtkListBox.html instead of EggListBox.
Comment 1 Guillaume Desmottes 2013-09-04 14:31:19 UTC 
Created attachment 254087 [details] [review]
depends on Gtk+ 3.9.4

Needed for GtkListBox.
Comment 2 Guillaume Desmottes 2013-09-04 14:31:24 UTC 
Created attachment 254088 [details] [review]
roster-contact: inherit from GtkListBoxRow

Need to be pack in a GtkListBox.
Comment 3 Guillaume Desmottes 2013-09-04 14:31:28 UTC 
Created attachment 254089 [details] [review]
roster-group: inherit from GtkListBoxRow

Need to be pack in a GtkListBox.
Comment 4 Guillaume Desmottes 2013-09-04 14:31:32 UTC 
Created attachment 254090 [details] [review]
roster-view: inherit from GtkListBox
Comment 5 Guillaume Desmottes 2013-09-04 14:31:36 UTC 
Created attachment 254091 [details] [review]
remove egg-list-box
Comment 6 Xavier Claessens 2013-09-04 15:17:13 UTC 
Review of attachment 254087 [details] [review]:

::: configure.ac
@@ +45,1 @@
 AC_DEFINE(GDK_VERSION_MIN_REQUIRED, GDK_VERSION_3_4, [Ignore post 3.4 deprecations])

If we still use deprecated stuff, please open a bug to bump MIN_REQUIRED to 3_10 as well.
Comment 7 Xavier Claessens 2013-09-04 15:19:06 UTC 
patches looks good to me, +1.
Comment 8 Guillaume Desmottes 2013-09-05 07:09:51 UTC 
(In reply to comment #6)
> Review of attachment 254087 [details] [review]:
> 
> ::: configure.ac
> @@ +45,1 @@
>  AC_DEFINE(GDK_VERSION_MIN_REQUIRED, GDK_VERSION_3_4, [Ignore post 3.4
> deprecations])
> 
> If we still use deprecated stuff, please open a bug to bump MIN_REQUIRED to
> 3_10 as well.

bug #707538
Comment 9 Guillaume Desmottes 2013-09-05 07:10:17 UTC 
Attachment 254087 [details] pushed as 1c2c498 - depends on Gtk+ 3.9.4
Attachment 254088 [details] pushed as 0e9e3cf - roster-contact: inherit from GtkListBoxRow
Attachment 254089 [details] pushed as a2b853f - roster-group: inherit from GtkListBoxRow
Attachment 254090 [details] pushed as 505ec40 - roster-view: inherit from GtkListBox
Attachment 254091 [details] pushed as 9f41e5e - remove egg-list-box