After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706955 - autoaudiosink/autovideosink: Introduce "sync" property
autoaudiosink/autovideosink: Introduce "sync" property
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.1.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2013-08-28 06:37 UTC by Bernhard Miller
Modified: 2013-09-18 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch to introduce "sync" property in autoaudiosink (3.26 KB, patch)
2013-08-28 06:37 UTC, Bernhard Miller
committed Details | Review
Patch to add "sync" property to autovideosink (3.29 KB, patch)
2013-08-28 08:59 UTC, Bernhard Miller
committed Details | Review

Description Bernhard Miller 2013-08-28 06:37:08 UTC
Created attachment 253341 [details] [review]
Patch to introduce "sync" property in autoaudiosink

Comment 1 Sebastian Dröge (slomo) 2013-08-28 08:26:55 UTC
For consistency this should be added to autovideosink too then. Note that this doesn't solve the problem in general, you are still not guaranteed that every sink implements that. They could still be a bin or a generic GstElement or whatever.

Also all these property proxies in autoaudiosink should probably first check if the child element actually has this property... and set the child property when it is created (which is missing in your patch, see the ts-offset handling in gst_auto_audio_sink_detect).
Comment 2 Bernhard Miller 2013-08-28 08:44:00 UTC
I agree that it would be nice to have better handling of missing properties. However, I just copied the code for ts-offset to provide the required functionality for my use case. 

The child property is set after child creation, similar to ts-offset. 
See attached patch, line 52ff:

@@ -336,6 +344,7 @@ gst_auto_audio_sink_detect (GstAutoAudioSink * sink)
     goto no_sink;
   g_object_set (G_OBJECT (esink), "ts-offset", sink->ts_offset, NULL);
+  g_object_set (G_OBJECT (esink), "sync", sink->sync, NULL);
   sink->kid = esink;
   /* Ensure the child is brought up to the right state to match the parent
Comment 3 Bernhard Miller 2013-08-28 08:59:24 UTC
Created attachment 253351 [details] [review]
Patch to add "sync" property to autovideosink

Add "sync" property to autovideosink
Comment 4 Sebastian Dröge (slomo) 2013-08-29 10:23:56 UTC
Oh sorry, for some reason I missed that in the original patch. Thanks for the autovideosink patch too :)

commit f7528d274b56f38a93461cb6f10bdf9775d52ba8
Author: Bernhard Miller <>
Date:   Wed Aug 28 10:51:32 2013 +0200

    autovideosink: add sync property

commit 2fa68fce077a738821373ec8c16d90485ff4d697
Author: Bernhard Miller <>
Date:   Wed Aug 28 07:15:00 2013 +0200

    autoaudiosink: introduce sync property