After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706928 - [New feature] Adding support for clearTextsize attribute in res element
[New feature] Adding support for clearTextsize attribute in res element
Status: RESOLVED FIXED
Product: gupnp-av
Classification: Other
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks: 705564
 
 
Reported: 2013-08-27 20:47 UTC by Parthiban Balasubramanian
Modified: 2019-02-22 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support for adding clearTextsize attribute for link protected content. (15.08 KB, patch)
2013-08-27 20:47 UTC, Parthiban Balasubramanian 		needs-work Details | Review
Support for adding clearTextsize attribute for link protected item (12.24 KB, patch)
2013-09-03 20:02 UTC, Parthiban Balasubramanian 		committed Details | Review

Description Parthiban Balasubramanian 2013-08-27 20:47:09 UTC 
Created attachment 253308 [details] [review]
Support for adding clearTextsize attribute for link protected content.

clearTextSize attribute must be added if the content is dtcp link protected along with a dlna prefix and dlna namespace.
Added changes to didl-lite-writer to top-level dlna namespace declaration in browse/search only when a dlna attribute is available.
Comment 1 Jens Georg 2013-09-03 12:33:42 UTC 
Review of attachment 253308 [details] [review]:

This looks like there's also code for bug 705564 in this patch...
Comment 2 Parthiban Balasubramanian 2013-09-03 20:02:15 UTC 
Created attachment 254014 [details] [review]
Support for adding clearTextsize attribute for link protected item
Comment 3 Parthiban Balasubramanian 2013-09-03 20:03:10 UTC 
My bad. Clubbed two patched together. I will be updating bug 705564 with the corresponding patch.
Comment 4 Jens Georg 2013-09-30 13:15:17 UTC 
Review of attachment 254014 [details] [review]:

there are minor style issues as well (tabs vs. spaces)

::: libgupnp-av/gupnp-didl-lite-resource.c
@@ +1294,3 @@
+                              (unsigned char *) "cleartextSize", 
+                              (unsigned char *) str);
+{

I don't understand this part of the code
Comment 5 Parthiban Balasubramanian 2013-09-30 13:41:28 UTC 
Review of attachment 254014 [details] [review]:

::: libgupnp-av/gupnp-didl-lite-resource.c
@@ +1294,3 @@
+                              (unsigned char *) "cleartextSize", 
+                              (unsigned char *) str);
+{

This block checks if the dlna namespace node has already been created for the presence of anyother dlna namespaced properties. To avoid creating dlnans over and over again.
Comment 6 Jens Georg 2013-10-16 11:44:01 UTC 
Pushed with slight fixes for style and vapi generation