After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706892 - Add TpawClientFactory
Add TpawClientFactory
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: tp-aw
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-27 14:01 UTC by Marco Barisione
Modified: 2018-05-22 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
avatar-chooser: make the file chooser dialog modal (1.27 KB, patch)
2013-08-27 14:04 UTC, Marco Barisione
rejected Details | Review

Description Marco Barisione 2013-08-27 14:01:40 UTC
Ideally we should add a TpawClientFactory class, derived from TpSimpleClientFactory, to set some default features we need in tp-aw (like TP_ACCOUNT_FEATURE_STORAGE, TP_ACCOUNT_FEATURE_CONNECTION, TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS and TP_CONNECTION_FEATURE_CONTACT_INFO).

Them we should get EmpathyClientFactory to derive from it.

At the moment things (mostly) work because Empathy uses EmpathyClientFactory and GOA just sets a bunch of features it needs.
Comment 1 Marco Barisione 2013-08-27 14:04:54 UTC
Created attachment 253249 [details] [review]
avatar-chooser: make the file chooser dialog modal

https://bugzilla.gnome.org/show_bug.cgi?id=706881
Comment 2 Marco Barisione 2013-08-27 14:06:06 UTC
Comment on attachment 253249 [details] [review]
avatar-chooser: make the file chooser dialog modal

Attached this patch by mistake. I have no patch for this yet.
Comment 3 GNOME Infrastructure Team 2018-05-22 16:18:22 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/734.