After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706872 - mpegtsmux does not flag key frames properly for tcpserversink
mpegtsmux does not flag key frames properly for tcpserversink
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.2.0
Other Linux
: Normal major
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-27 09:44 UTC by Peter Maersk-Moller
Modified: 2015-03-15 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Peter Maersk-Moller 2013-08-27 09:44:31 UTC
It appear that the current 1.0.9 version of mpegtsmux does not flag the key frame properly. This affects other modules such as tcpserversink that are then unable to determine correct from where in a stream it should start sending out a TS stream.

Please see intital mail
http://lists.freedesktop.org/archives/gstreamer-devel/2013-August/042628.html
http://lists.freedesktop.org/archives/gstreamer-devel/2013-August/042635.html

And please see Tim-Phillipps mail suggesting filing a bug report for mpegtsmux
http://lists.freedesktop.org/archives/gstreamer-devel/2013-August/042668.html
Comment 1 Peter Maersk-Moller 2013-09-26 08:35:37 UTC
TS-muxing in combination with tcpclientsrc still broken in 1.2
See also thread http://lists.freedesktop.org/archives/gstreamer-devel/2013-September/043142.html
Comment 2 Peter Maersk-Moller 2013-09-26 10:06:28 UTC
(In reply to comment #1)
> TS-muxing in combination with tcpclientsrc still broken in 1.2
> See also thread
> http://lists.freedesktop.org/archives/gstreamer-devel/2013-September/043142.html

I should have stated 'with tcpserversink' and not 'with tcpclientsrc' although a tcpserversink in some cases implies a tcpclientsrc in the other end. Anyway, I believe the issue is with mpegtsmux, which affects other plugins/elements using a flagged keyframe such as tcpserversink.
Comment 3 Tim-Philipp Müller 2015-03-15 16:09:41 UTC
This seems to work fine for me now with git master. I've added a unit test too.

commit ec6e93d45fc04953489b00857656f779289d610b
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun Mar 15 15:54:01 2015 +0000

    tests: mpegtsmux: add test for keyframe/delta flag propagation
    
    The first output MPEG-TS packet that corresponds to a video input
    buffer which had the delta flag cleared (i.e. was a keyframe)
    should have the delta flag cleared as well.
    
    This is needed e.g. by tcpserversink in order to keep track
    of the last keyframe and be able to burst data to newly-
    connected clients.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706872