After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706871 - build: don't use GTK_DISABLE_DEPRECATION
build: don't use GTK_DISABLE_DEPRECATION
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-27 09:37 UTC by Giovanni Campagna
Modified: 2013-08-29 08:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: don't use GTK_DISABLE_DEPRECATION (1.33 KB, patch)
2013-08-27 09:39 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-08-27 09:37:13 UTC 
It breaks the build when Gtk deprecates API, and buys nothing
over -Wdeprecated-declarations.
Comment 1 Giovanni Campagna 2013-08-27 09:39:35 UTC 
Created attachment 253231 [details] [review]
build: don't use GTK_DISABLE_DEPRECATION
Comment 2 Claudio Saavedra 2013-08-27 10:10:24 UTC 
You can just build without maintainer-mode and the build will be fine. Also you're removing much more than just GTK_DISABLE_DEPRECATED.
Comment 3 Giovanni Campagna 2013-08-27 10:13:09 UTC 
I'm removing all deprecation flags, because they all behave the same, and they are all dangerous.

Also, building without maintainer mode is not an option, for two reasons:
1) I want the Makefiles to be updated when Makefile.am changes
2) --enable-maintainer-mode is added by gnome-autogen.sh, and is part of the default jhbuild configuration, and I want something that works out of the box for every jhbuild user
Comment 4 Claudio Saavedra 2013-08-28 19:05:24 UTC 
Review of attachment 253231 [details] [review]:

OK, let's just do this for now.
Comment 5 Giovanni Campagna 2013-08-29 08:31:02 UTC 
Attachment 253231 [details] pushed as afec346 - build: don't use GTK_DISABLE_DEPRECATION