After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706846 - build fails due to side-by-side IT_PROG_INTLTOOL and AM_GNU_GETTEXT
build fails due to side-by-side IT_PROG_INTLTOOL and AM_GNU_GETTEXT
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-26 22:38 UTC by Seán de Búrca
Modified: 2013-08-28 18:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix build (808 bytes, patch)
2013-08-26 22:38 UTC, Seán de Búrca 		committed Details | Review
define ENABLE_NLS if NLS is used (959 bytes, patch)
2013-08-28 16:20 UTC, David King 		committed Details | Review

Description Seán de Búrca 2013-08-26 22:38:51 UTC 
Created attachment 253197 [details] [review]
Patch to fix build

Per https://bugzilla.gnome.org/show_bug.cgi?id=705365, using both
IT_PROG_INTLTOOL and AM_GNU_GETTEXT is unsupported. Changes in gnome-common
master cause build to break with this combination.
Comment 1 Sébastien Wilmet 2013-08-27 10:48:02 UTC 
Review of attachment 253197 [details] [review]:

Thanks for the patch. Looks good. Do you have push rights?
Comment 3 Sébastien Wilmet 2013-08-27 20:10:50 UTC 
Now I get the following warning messages:

> gtksourceview-i18n.c: In function '_gtksourceview_gettext':
> gtksourceview-i18n.c:81:3: warning: statement with no effect [-Wunused-value]
> gtksourceview-i18n.c:84:3: warning: statement with no effect [-Wunused-value]

Before your patch, these warnings appeared only when using the --disable-nls configure option. Now it seems that ENABLE_NLS is always false (or more precisely, not defined).

For the commit message, just a little nitpick, you forgot to add an empty line after the title (see the HACKING file for the instructions on commit messages).
Comment 4 Ignacio Casal Quinteiro (nacho) 2013-08-28 06:12:46 UTC 
fyi, I think we tried this before and we ended up reverting the patches since the software was not translated anymore...
Comment 5 Seán de Búrca 2013-08-28 15:31:33 UTC 
It appears that bindtextdomain wants to see ENABLE_NLS defined or it won't do anything. I'm a little confused, as gnome-shell (which I patched similarly) appears to be localized correctly, but on testing that doesn't appear to be the case for gtksourceview. I'm looking into alternatives.
Comment 6 David King 2013-08-28 16:20:14 UTC 
Created attachment 253411 [details] [review]
define ENABLE_NLS if NLS is used

The attached patch solves the warnings by using AC_DEFINE to define ENABLE_NLS if NLS is used. It fixes the warnings for me.
Comment 7 Seán de Búrca 2013-08-28 16:34:36 UTC 
David's patch appears to be the correct behavior. IT_PROG_INTLTOOL should define ENABLE_NLS upstream, and I've filed a bug against upstream to that effect: https://bugs.launchpad.net/intltool/+bug/1217976. In the meantime, I believe the patch should resolve the issue.
Comment 8 Sébastien Wilmet 2013-08-28 18:01:11 UTC 
Review of attachment 253411 [details] [review]:

Thanks, I've tested, and the translations work again. And the --disable-nls option works too.