After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706843 - Remove the use of constraints from the unlock dialog / gdm
Remove the use of constraints from the unlock dialog / gdm
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-26 21:54 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-08-26 23:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
unlockDialog: Remove clutter constraints from the code (2.75 KB, patch)
2013-08-26 21:54 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
gdm: Remove constraints from authPrompt / loginDialog as well (5.57 KB, patch)
2013-08-26 21:54 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
gdm: Remove constraints from authPrompt / loginDialog as well (6.32 KB, patch)
2013-08-26 22:24 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-08-26 21:54:20 UTC 
They just spew spam to stdout.

Second patch is untested and is probably broken.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-08-26 21:54:21 UTC 
Created attachment 253189 [details] [review]
unlockDialog: Remove clutter constraints from the code

These cause annoying allocation cycle warnings, and it's simpler to
just express our desired layout in terms of nested containers.
Adapt the theme to match as well.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-26 21:54:24 UTC 
Created attachment 253190 [details] [review]
gdm: Remove constraints from authPrompt / loginDialog as well
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-08-26 22:24:19 UTC 
Created attachment 253193 [details] [review]
gdm: Remove constraints from authPrompt / loginDialog as well

This time, actually tested and verified as working.
Comment 4 Ray Strode [halfline] 2013-08-26 22:45:06 UTC 
both look right to me. things are centered in the way they're supposed to be etc.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-08-26 23:05:30 UTC 
Attachment 253189 [details] pushed as 1f50f46 - unlockDialog: Remove clutter constraints from the code
Attachment 253193 [details] pushed as 41aa14e - gdm: Remove constraints from authPrompt / loginDialog as well