After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706842 - build fails due to side-by-side IT_PROG_INTLTOOL and AM_GNU_GETTEXT and missing IT_PROG_INTLTOOL macro
build fails due to side-by-side IT_PROG_INTLTOOL and AM_GNU_GETTEXT and missi...
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-26 21:49 UTC by Seán de Búrca
Modified: 2013-08-27 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix build (1016 bytes, patch)
2013-08-26 21:49 UTC, Seán de Búrca 		committed Details | Review

Description Seán de Búrca 2013-08-26 21:49:41 UTC 
Created attachment 253188 [details] [review]
Patch to fix build

Due to changes in gnome-common git, an implicit m4 directory is no longer
created during autogen. The attached patch explicitly and correctly specifies a
macro directory. Additionally, per https://bugzilla.gnome.org/show_bug.cgi?id=705365, using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT is unsupported. Changes in gnome-common master cause build to break with this combination.
Comment 1 David King 2013-08-27 14:33:54 UTC 
Review of attachment 253188 [details] [review]:

The change looks fine to me (as a gnome-common maintainer), but you might want to split the commit message so that it has a one-line (less than 72 characters) message, then a blank line, then the remainder of the message. Also, please link to this bug in the commit message before pushing.