GNOME Bugzilla – Bug 706826
build fails due to missing IT_PROG_INTLTOOL macro
Last modified: 2013-08-29 15:12:35 UTC
Created attachment 253170 [details] [review] Patch to fix build Due to changes in gnome-common git, an implicit m4 directory is no longer created during autogen. The attached patch explicitly and correctly specifies a macro directory.
Review of attachment 253170 [details] [review]: ACLOCAL_AMFLAGS is already set, right at the top of Makefile.am. I’ve just successfully configured and built folks from a clean checkout using gnome-common git master. What’s your build configuration and what build error do you get?
Created attachment 253218 [details] [review] Revised patch to fix build This may have to do with a pending patch to gnome-common I submitted which is necessary for proper functioning in a number of other packages. Using the patch from https://bugzilla.gnome.org/show_bug.cgi?id=705365 in gnome-common on a clean folks tree through jhbuild, IT_PROG_INTLTOOL is not found. I missed the existing ACLOCAL_AMFLAGS declaration due to the pace at which I was filing these bugs. The patch I am attaching uses the existing declaration but includes ${ACLOCAL_FLAGS}. This is sufficient to solve the problem for me.
Review of attachment 253218 [details] [review]: Looks good to me, although I’m struggling to find any documentation on ACLOCAL_FLAGS *anywhere*. Do you have some handy? Please commit it to master anyway, and make sure to update the NEWS file in your commit. Thanks for working on this (and filing bugs against everything). Have you updated the documentation which advises people to add “ACLOCAL_AMFLAGS = -I m4” without the ACLOCAL_FLAGS reference?
All I've been able to find that elucidates anything is an email from 2009 to the autoconf mailing list: http://lists.gnu.org/archive/html/autoconf/2009-07/msg00002.html Which documentation are you referring to? I can certainly write a patch for it. I'm not too familiar with any GNOME documentation on build systems, but it's worth noting that https://wiki.gnome.org/GnomeGoals/ModernAutotools lists ${ACLOCAL_FLAGS}. (It's only a proposed goal at this point, however.)
(In reply to comment #4) > All I've been able to find that elucidates anything is an email from 2009 to > the autoconf mailing list: > http://lists.gnu.org/archive/html/autoconf/2009-07/msg00002.html That’s a pain. Looks like it would be well worth submitting a patch to autoconf to add some appropriate documentation. It’ll save lots of people lots of puzzling in the future. > Which documentation are you referring to? I can certainly write a patch for it. > I'm not too familiar with any GNOME documentation on build systems, but it's > worth noting that https://wiki.gnome.org/GnomeGoals/ModernAutotools lists > ${ACLOCAL_FLAGS}. (It's only a proposed goal at this point, however.) After Googling a few things, I’m fairly satisfied that I was thinking of this documentation: • https://wiki.gnome.org/GObjectIntrospection/AutotoolsIntegration which I’ve just updated. I think that’s everything. :-)
Comment on attachment 253218 [details] [review] Revised patch to fix build Committed to master, thanks. commit 67963cd34489610325a0eb87dcb288633ef572a3 Author: Seán de Búrca <leftmostcat@gmail.com> Date: Mon Aug 26 23:00:47 2013 -0600 build: Fix autogen and configure Include ACLOCAL_FLAGS when setting. ACLOCAL_AMFLAGS. Closes: https://bugzilla.gnome.org/show_bug.cgi?id=706826 Makefile.am | 2 +- NEWS | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)