GNOME Bugzilla – Bug 706810
Remove emphasis on Cancel button
Last modified: 2013-08-30 11:30:39 UTC
The new mockups at https://wiki.gnome.org/GnomeOS/Design/Whiteboards/SelectionPattern do not have "suggested-action" style class in its Cancel button.
Created attachment 253143 [details] [review] main-toolbar: Remove emphasis on Cancel button This is to follow the new design for Content Selection Pattern.
Review of attachment 253143 [details] [review]: Looks good. However we are in UI Freeze (https://wiki.gnome.org/ReleasePlanning/Freezes#UI_Freeze) so we need to ask the Release Team and notify the Documentation Team before we commit this.
Review of attachment 253143 [details] [review]: ::: src/photos-main-toolbar.c @@ -492,3 +492,2 @@ gtk_header_bar_pack_end (GTK_HEADER_BAR (priv->toolbar), selection_button); context = gtk_widget_get_style_context (selection_button); - gtk_style_context_add_class (context, "suggested-action"); You should remove the previous statement too, and the context variable is unused then its definition as well.
Created attachment 253229 [details] [review] main-toolbar: Remove emphasis on Cancel button Addresses the issues found in the previous patch. We still need to ask for permission before we commit this.
Thanks for updating and committing my patch! I was in a hurry on that day so I forgot to remove the unnecessary code.