After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706810 - Remove emphasis on Cancel button
Remove emphasis on Cancel button
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-26 15:25 UTC by Arnel Borja
Modified: 2013-08-30 11:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
main-toolbar: Remove emphasis on Cancel button (1.09 KB, patch)
2013-08-26 15:25 UTC, Arnel Borja
needs-work Details | Review
main-toolbar: Remove emphasis on Cancel button (1.46 KB, patch)
2013-08-27 09:36 UTC, Debarshi Ray
committed Details | Review

Description Arnel Borja 2013-08-26 15:25:36 UTC
The new mockups at https://wiki.gnome.org/GnomeOS/Design/Whiteboards/SelectionPattern do not have "suggested-action" style class in its Cancel button.
Comment 1 Arnel Borja 2013-08-26 15:25:39 UTC
Created attachment 253143 [details] [review]
main-toolbar: Remove emphasis on Cancel button

This is to follow the new design for Content Selection Pattern.
Comment 2 Debarshi Ray 2013-08-27 07:33:09 UTC
Review of attachment 253143 [details] [review]:

Looks good.

However we are in UI Freeze (https://wiki.gnome.org/ReleasePlanning/Freezes#UI_Freeze) so we need to ask the Release Team and notify the Documentation Team before we commit this.
Comment 3 Debarshi Ray 2013-08-27 07:35:23 UTC
Review of attachment 253143 [details] [review]:

::: src/photos-main-toolbar.c
@@ -492,3 +492,2 @@
   gtk_header_bar_pack_end (GTK_HEADER_BAR (priv->toolbar), selection_button);
   context = gtk_widget_get_style_context (selection_button);
-  gtk_style_context_add_class (context, "suggested-action");

You should remove the previous statement too, and the context variable is unused then its definition as well.
Comment 4 Debarshi Ray 2013-08-27 09:36:29 UTC
Created attachment 253229 [details] [review]
main-toolbar: Remove emphasis on Cancel button

Addresses the issues found in the previous patch. We still need to ask for permission before we commit this.
Comment 5 Arnel Borja 2013-08-30 11:30:39 UTC
Thanks for updating and committing my patch! I was in a hurry on that day so I forgot to remove the unnecessary code.