After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706797 - Upload fails for some media types
Upload fails for some media types
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: MediaExport plugin
git master
Other Linux
: Normal normal
: ---
Assigned To: Jens Georg
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-26 12:37 UTC by regis.merlino
Modified: 2013-08-28 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix the empty upload_profiles list (1012 bytes, patch)
2013-08-27 09:09 UTC, regis.merlino
committed Details | Review

Description regis.merlino 2013-08-26 12:37:03 UTC
Trying to upload some files that used to work with previous Rygel versions now fail:

(lt-rygel:13218): Rygel-WARNING **: Failed to create item under '29d2939b9a77278c2314d551befdf8d2': DLNA profile 'JPEG_SM' not supported

(lt-rygel:13218): Rygel-WARNING **: Failed to create item under '29d2939b9a77278c2314d551befdf8d2': DLNA profile 'PNG_TN' not supported


The upload works fine with .ogg, .mp4 files, but fails for .jpg, .png for instance.
Comment 1 Jens Georg 2013-08-26 15:48:10 UTC
JPEG_SM is weird. PNG_TN is not much of a bug because it should only be used for thumbnails; files present in the DLNA server should use PNG_LRG only (That's defined somewhere in the media format guidelines IIRC, at least we had to remove *_TN and *_ICO profiles from Rygel for certification)

Is the client using X_GetDLNAUploadProfiles?
Comment 2 regis.merlino 2013-08-26 16:07:43 UTC
No the client app does not make use of X_GetDLNAUploadProfile.

I get errors for JPEG_LRG and PNG_LRG too:

(lt-rygel:17050): Rygel-WARNING **: Failed to create item under '29d2939b9a77278c2314d551befdf8d2': DLNA profile 'PNG_LRG' not supported

(lt-rygel:17050): Rygel-WARNING **: Failed to create item under '29d2939b9a77278c2314d551befdf8d2': DLNA profile 'JPEG_LRG' not supported
Comment 3 Jens Georg 2013-08-27 09:06:06 UTC
Yeah, I can reproduce this.
Comment 4 regis.merlino 2013-08-27 09:08:51 UTC
After debugging, the problem comes from Rygel.MediaServerPlugin::upload_profiles that returned an empty list.

I am attaching a patch proposal to fix this.
Comment 5 regis.merlino 2013-08-27 09:09:49 UTC
Created attachment 253227 [details] [review]
Fix the empty upload_profiles list
Comment 6 Jens Georg 2013-08-28 09:42:39 UTC
Thanks!