After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706796 - Increase padding between system icons in top bar
Increase padding between system icons in top bar
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-26 12:31 UTC by Allan Day
Modified: 2013-08-28 13:41 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10


Attachments
simple theme patch (744 bytes, patch)
2013-08-26 12:54 UTC, Allan Day
accepted-commit_now Details | Review
Before and after screenshots (5.84 KB, image/png)
2013-08-26 12:56 UTC, Allan Day
  Details
patch (864 bytes, patch)
2013-08-27 18:59 UTC, Allan Day
committed Details | Review

Description Allan Day 2013-08-26 12:31:02 UTC
The icons are quite closely packed, which makes it a bit difficult to "read" them, and looks a bit cramped. Increasing the padding would also make the click target bigger.

It's just a minor padding change, but we're past UI freeze.
Comment 1 Allan Day 2013-08-26 12:54:29 UTC
Created attachment 253130 [details] [review]
simple theme patch
Comment 2 Allan Day 2013-08-26 12:56:33 UTC
Created attachment 253131 [details]
Before and after screenshots

Before is on top, bottom is below. This looks good when the a11y and input sources menus are not displayed. When they are, the padding on the left of the triangles becomes a bit of an issue. It might be OK though.
Comment 3 Florian Müllner 2013-08-26 12:58:44 UTC
Review of attachment 253130 [details] [review]:

I'm not sure it's big enough a change to bother doc/release team with it, but feel free to ask if you disagree :-)
Comment 4 Frederic Peters 2013-08-26 13:18:37 UTC
Speaking with my release team hat on, I think it's fine not to ask for such pixel changes at this moment.
Comment 5 Allan Day 2013-08-26 13:19:30 UTC
Oops, I already asked...
Comment 6 Matthias Clasen 2013-08-26 14:40:36 UTC
I'll give you a +1 here
Comment 7 Allan Day 2013-08-27 18:59:49 UTC
Created attachment 253291 [details] [review]
patch

Updated patch that keeps the disclosure triangle a bit closer to the icons.
Comment 8 Allan Day 2013-08-28 13:41:07 UTC
I got two or three +1s and no objections, so pushed.