After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706789 - gschema will not be translated because of invalid gettext-domain
gschema will not be translated because of invalid gettext-domain
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.9.x
Other All
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-26 10:27 UTC by Jiro Matsuzawa
Modified: 2013-08-26 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace @GETTEXT_PACKAGE@ with actual package name (928 bytes, patch)
2013-08-26 10:30 UTC, Jiro Matsuzawa 		none Details | Review
Replace @GETTEXT_PACKAGE@ with actual package name (946 bytes, patch)
2013-08-26 10:56 UTC, Jiro Matsuzawa 		none Details | Review
Move gettext-domain attr from schema to schemalist (916 bytes, patch)
2013-08-26 13:07 UTC, Jiro Matsuzawa 		committed Details | Review

Description Jiro Matsuzawa 2013-08-26 10:27:38 UTC 
org.gnome.clocks.gschema.xml.in has @GETTEXT_PACKAGE@ as the output variable for its domain name. However, it is not substituted with the proper domain, "gnome-clocks", in the build process. @GETTEXT_PACKAGE@ remains in org.gnome.clocks.gschema.xml. As a result, the strings in the schema file won't be translated.

Here is org.gnome.clocks.gschema.xml:
<?xml version="1.0" encoding="UTF-8"?>
<schemalist>
  <schema path="/org/gnome/clocks/" id="org.gnome.clocks" gettext-domain="@GETTEXT_PACKAGE@">
(...snip...)
  </schema>
</schemalist>
Comment 1 Jiro Matsuzawa 2013-08-26 10:30:26 UTC 
Created attachment 253107 [details] [review]
Replace @GETTEXT_PACKAGE@ with actual package name

This is just a quick fix. I think it's worth reforming the build scripts, but that would have a too large impact for imminent 3.10.
Comment 2 Jiro Matsuzawa 2013-08-26 10:56:56 UTC 
Created attachment 253115 [details] [review]
Replace @GETTEXT_PACKAGE@ with actual package name

Oops, the gschema files has other schemas. So, we should put the gettext-domain attribute in the <schemalist> element rather than each <schema> element.
Comment 3 Paolo Borelli 2013-08-26 12:32:25 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.


https://git.gnome.org/browse/gnome-clocks/commit/?id=46e23d1e5035cc5d7b10d3f9cd9888bd3e770cf2
Comment 4 Jiro Matsuzawa 2013-08-26 13:07:48 UTC 
Created attachment 253132 [details] [review]
Move gettext-domain attr from schema to schemalist

Thank you for fixing it. But there is one more thing to do. We need to move the gettext-domain attribute from <schema> element to <schemalist> element or add the attribute to each <schema>.
Comment 5 Jiro Matsuzawa 2013-08-26 13:08:20 UTC 
Reopened.
Comment 6 Paolo Borelli 2013-08-26 13:22:10 UTC 
Review of attachment 253132 [details] [review]:

sure, go ahead