After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706785 - build fails due to missing IT_PROG_INTLTOOL macro
build fails due to missing IT_PROG_INTLTOOL macro
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
: 707941 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-08-26 09:51 UTC by Seán de Búrca
Modified: 2013-10-22 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix build (727 bytes, patch)
2013-08-26 09:51 UTC, Seán de Búrca
none Details | Review
intltool build fix by Seán de Búrca (1.18 KB, patch)
2013-10-22 10:07 UTC, Jakub Steiner
none Details | Review

Description Seán de Búrca 2013-08-26 09:51:13 UTC
Created attachment 253100 [details] [review]
Patch to fix build

Due to changes in gnome-common git, an implicit m4 directory is no longer created during autogen. The attached patch explicitly and correctly specifies a macro directory.
Comment 1 Jakub Steiner 2013-08-26 10:07:25 UTC
Thank you for the patch. Would you mind resubmitting the patch with your metadata using git format-patch?
Comment 2 Jakub Steiner 2013-08-26 10:44:08 UTC
Pushed the fix as c2f166f58677b5a5c5492afc19f289efa02923a4
Comment 3 Seán de Búrca 2013-08-26 10:45:30 UTC
For future reference, how should I use the above command?
Comment 4 Jakub Steiner 2013-08-26 11:30:11 UTC
(In reply to comment #3)
> For future reference, how should I use the above command?

Commit your change in your local tree with appropriate description and create the diff with something like `git format-patch HEAD^`
Comment 5 Jakub Steiner 2013-09-03 15:57:18 UTC
Reopening as it's not really working on this F19 box:

Checking for required M4 macros...
Checking for forbidden M4 macros...
Processing ./configure.ac
Running intltoolize...
cp: cannot create regular file ‘m4/intltool.m4’: No such file or directory
intltoolize: cannot copy '/usr/share/aclocal/intltool.m4' to 'm4/intltool.m4'
Comment 6 Seán de Búrca 2013-09-03 16:48:19 UTC
I've experienced the same problem with other packages which have not had the above patch applied (e.g., jhbuild). I'm unsure why it's occurring, but I believe it to be a different bug.
Comment 7 Robert Roth 2013-10-22 08:45:51 UTC
*** Bug 707941 has been marked as a duplicate of this bug. ***
Comment 8 Jakub Steiner 2013-10-22 10:07:30 UTC
Created attachment 257831 [details] [review]
intltool build fix by Seán de Búrca
Comment 9 Jakub Steiner 2013-10-22 10:09:42 UTC
I really don't grok any of autotools or intltool, but the patch does work 
on F20 again and if it's fine for davidz, it's probably fine for us :)