After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706740 - a typo in gtk_icon_view_key_release()
a typo in gtk_icon_view_key_release()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkIconView
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-08-25 08:13 UTC by Vadim Ushakov
Modified: 2013-08-31 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vadim Ushakov 2013-08-25 08:13:29 UTC
Hi!

It seems there is a typo in gtk_icon_view_key_release() :

static gboolean
gtk_icon_view_key_release (GtkWidget      *widget,
			   GdkEventKey    *event)
{
  GtkIconView *icon_view = GTK_ICON_VIEW (widget);

  if (icon_view->priv->doing_rubberband)
    return TRUE;

  return GTK_WIDGET_CLASS (gtk_icon_view_parent_class)->key_press_event (widget, event);
}

The return statement probably should call key_release_event(), not key_press_event().

That bug affect both gtk2 and gtk3.