GNOME Bugzilla – Bug 706729
GnomeRR: g-s-d backlight step up/down don't work anymore
Last modified: 2013-09-02 15:32:37 UTC
Since 3.9.90 setting the display backlight using keyboard shortcuts doesn't work anymore. I've tracked this down to gnome_rr_output_set_backlight not updating the stored backlight value correctly so gnome_rr_output_get_backlight would always report the old value. I'm attaching a patch that fixes the issue for me but I'm not sure if this is the best way to fix this.
Created attachment 253044 [details] [review] GnomeRR: store new backlight value after successfully setting it
Giovanni, you touched this last - does this seem right ?
Review of attachment 253044 [details] [review]: This is only partially correct, because it doesn't account for rounding caused by HW limits. I think we need to return the new value from the DBus call.
Created attachment 253145 [details] [review] GnomeRR: read the backlight value after asking mutter to change it Mutter now returns the new backlight value after a successfull call to ChangeBacklight, so we need to read it.
Created attachment 253146 [details] [review] MonitorManager: return the new backlight after changing Modify the interface of ChangeBacklight to return the new value, to account for rounding to HW limits.
Review of attachment 253145 [details] [review]: looks fine to me
Review of attachment 253146 [details] [review]: sure
Comment on attachment 253146 [details] [review] MonitorManager: return the new backlight after changing Attachment 253146 [details] pushed as a3037a6 - MonitorManager: return the new backlight after changing
Attachment 253145 [details] pushed as b150371 - GnomeRR: read the backlight value after asking mutter to change it
*** Bug 707290 has been marked as a duplicate of this bug. ***