After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706728 - pixelcache: allow specifying extra size and cairo_content_t of surface
pixelcache: allow specifying extra size and cairo_content_t of surface
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 701125
 
 
Reported: 2013-08-25 04:14 UTC by Christian Hergert
Modified: 2013-08-26 19:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pixelcache: allow specifying content type and extra size (5.71 KB, patch)
2013-08-25 04:14 UTC, Christian Hergert 		committed Details | Review

Description Christian Hergert 2013-08-25 04:14:36 UTC 
Created attachment 253041 [details] [review]
pixelcache: allow specifying content type and extra size

To implement pixelcache for textview, we need to specify the cairo_content_t of the surface to force rgba. This is because the text needs to be drawn separate from the background for static backgrounds.

Additionally, we need to specify the width and height. Might as well do this as one patch.
Comment 1 Ignacio Casal Quinteiro (nacho) 2013-08-26 06:16:15 UTC 
Review of attachment 253041 [details] [review]:

Minor comment from my part

::: gtk/gtkpixelcache.c
@@ +162,3 @@
   double red, green, blue, alpha;
 
+  if (!(content = cache->content))

to be more consistent with other parts of the code in gtk I'd split this:
content = cache->content;
if (!content)