After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706698 - media-keys: Merge keyboard/screen brightness code paths
media-keys: Merge keyboard/screen brightness code paths
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-24 00:37 UTC by Bastien Nocera
Modified: 2013-10-18 07:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-keys: Merge keyboard/screen brightness code paths (6.60 KB, patch)
2013-08-24 00:37 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-08-24 00:37:49 UTC 
.
Comment 1 Bastien Nocera 2013-08-24 00:37:52 UTC 
Created attachment 252962 [details] [review]
media-keys: Merge keyboard/screen brightness code paths

A lot of duplicated code here.
Comment 2 Rui Matos 2013-10-11 16:04:19 UTC 
Review of attachment 252962 [details] [review]:

Looks good otherwise

::: plugins/media-keys/gsd-media-keys-manager.c
@@ +1862,3 @@
 {
         GError *error = NULL;
+        guint percentage;

The DBus API does return a signed value. Not sure if it ever returns < 0 in practice nor what that would mean though. show_osd() takes a < 0 value as "don't show a level bar"...
Comment 3 Bastien Nocera 2013-10-18 07:41:39 UTC 
Fixed with the guint/int change

Attachment 252962 [details] pushed as 45d12a5 - media-keys: Merge keyboard/screen brightness code paths