GNOME Bugzilla – Bug 706696
updates: Notify about available offline updates
Last modified: 2013-08-27 11:55:54 UTC
gnome-shell no longer shows a menuitem when a prepared offline update is available, so the updates plugin needs to take over the responsibility and pop up a notification in this case. We monitor /var/lib/PackageKit/prepared-update and show a notification when the file is created. We don't show it more often than once every 5 minutes. To handle the case that the file already exists when gnome-settings-daemon is started, we check for its existence once, 5 minutes after starting. The notification offers to launch gnome-software to view details of the prepared update.
Created attachment 252960 [details] [review] updates: Notify about available offline updates
Created attachment 253117 [details] [review] updates: Notify about available offline updates gnome-shell no longer shows a menuitem when a prepared offline update is available, so the updates plugin needs to take over the responsibility and pop up a notification in this case. We monitor /var/lib/PackageKit/prepared-update and show a notification when the file is created. We don't show it more often than once every 5 minutes. To handle the case that the file already exists when gnome-settings-daemon is started, we check for its existence once, 5 minutes after starting. The notification offers to launch gnome-software to view details of the prepared update.
The new patch adds a fallback for when gnome-software is not installed - that seems advisable, since gnome-software is still pre-alpha, and we don't have another UI installing offline updates anymore.
Created attachment 253237 [details] [review] updates: Notify about available offline updates gnome-shell no longer shows a menuitem when a prepared offline update is available, so the updates plugin needs to take over the responsibility and pop up a notification in this case. We monitor /var/lib/PackageKit/prepared-update and show a notification when the file is created. We don't show it more often than once every 5 minutes. To handle the case that the file already exists when gnome-settings-daemon is started, we check for its existence once, 5 minutes after starting. The notification offers to launch gnome-software to view details of the prepared update. If gnome-software is not available, we just trigger the restart to install the updates directly from the notification.
Created attachment 253238 [details] [review] updates: Notify about available offline updates gnome-shell no longer shows a menuitem when a prepared offline update is available, so the updates plugin needs to take over the responsibility and pop up a notification in this case. We monitor /var/lib/PackageKit/prepared-update and show a notification when the file is created. We don't show it more often than once every 5 minutes. To handle the case that the file already exists when gnome-settings-daemon is started, we check for its existence once, 5 minutes after starting. The notification offers to launch gnome-software to view details of the prepared update. If gnome-software is not available, we just trigger the restart to install the updates directly from the notification.
Review of attachment 253238 [details] [review]: Looks good, thanks.
Attachment 253117 [details] pushed as 4067309 - updates: Notify about available offline updates Attachment 253237 [details] pushed as 4067309 - updates: Notify about available offline updates Attachment 253238 [details] pushed as 4067309 - updates: Notify about available offline updates