After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706670 - Controls move around when messages (password, fingerprint) are shown
Controls move around when messages (password, fingerprint) are shown
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-23 14:39 UTC by Allan Day
Modified: 2013-08-27 14:32 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10


Attachments
authPrompt: give message label an initial style (8.03 KB, patch)
2013-08-27 14:20 UTC, Ray Strode [halfline]
reviewed Details | Review
theme: add bottom badding for login dialog hint (1.49 KB, patch)
2013-08-27 14:31 UTC, Ray Strode [halfline]
committed Details | Review

Description Allan Day 2013-08-23 14:39:10 UTC
If we show a message below the password field (eg. swipe a finger, or incorrect password), the controls move around to make space. It's all a bit noisy.

It would be nicer if the space for the messages was preallocated, so they don't cause any movement when they are displayed.
Comment 1 Ray Strode [halfline] 2013-08-23 15:38:41 UTC
yea, we had that at one point and it broke. we should fix it again for sure.
Comment 2 Ray Strode [halfline] 2013-08-27 14:20:20 UTC
Created attachment 253253 [details] [review]
authPrompt: give message label an initial style

This commit consolidates the styles of the various
message types into one 'login-dialog-message' style
and then adds additional styles on top to cover the
differences.

This allows us to give the message label an initial
style so that is padded properly before any messages
are displayed.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-08-27 14:23:32 UTC
Review of attachment 253253 [details] [review]:

OK.
Comment 4 Ray Strode [halfline] 2013-08-27 14:24:16 UTC
Attachment 253253 [details] pushed as 88e3f6a - authPrompt: give message label an initial style
Comment 5 Giovanni Campagna 2013-08-27 14:25:04 UTC
Review of attachment 253253 [details] [review]:

::: data/theme/gnome-shell.css
@@ +2446,2 @@
 .login-dialog-message-hint {
+    padding-top: 0px;

Uhm, the padding changes if we show an hint, so the controls still move.
Comment 6 Ray Strode [halfline] 2013-08-27 14:31:29 UTC
Created attachment 253258 [details] [review]
theme: add bottom badding for login dialog hint

Since we're getting rid of the top padding, we need to add what we
take away to the bottom padding to keep the size the same.
Comment 7 Ray Strode [halfline] 2013-08-27 14:32:01 UTC
Attachment 253258 [details] pushed as 268ac0b - theme: add bottom badding for login dialog hint