GNOME Bugzilla – Bug 706662
Launch g-c-c instead of empathy-accounts
Last modified: 2018-05-22 16:17:41 UTC
With #706148 and #696267 fixed, gnome-control-center can now handle Telepathy accounts too. This means that Empathy should open g-c-c instead of opening empathy-accounts to avoid some duplicated UI. g-c-c can be opened with D-Bus and we will be able to display a specific account when #706648 will be merged. empathy-accounts is still fully functional and doesn't depend on g-c-c or GOA. What should we do with it? I think that, if we remove it completely, users of other desktops (XFCE and KDE) could be annoyed. Ubuntu is not a concern as they use UOA anyway. Some options are: 1) Just throw it away 2) Try to open g-c-c, if it's not activated open empathy-accounts 3) Open g-c-c if running under Gnome (I guess that is some environment variable we can rely on), empathy-accounts otherwise
Throwing it away completely cannot be an option. It should always be the last most thing to fallback on. I guess I'll give my vote to option 3.
I'd say 2) if it's fast enough (ie: we don't have to wait for a D-Bus timeout) or 3).
Created attachment 253137 [details] [review] accounts-dialog: make the UOA code more generic so we can use it for GOA
Created attachment 253138 [details] [review] accounts-dialog: open gnome-control-center for accounts if available
Created attachment 253139 [details] [review] accounts-dialog: open g-c-c properly in make use_external_storage_provider() By using the D-Bus interface of gnome-control-center we can open the panel on a specific account.
(In reply to comment #2) > I'd say 2) if it's fast enough (ie: we don't have to wait for a D-Bus timeout) > or 3). It fails immediately if it cannot be activated.
Review of attachment 253137 [details] [review]: ++
Review of attachment 253138 [details] [review]: ++
Review of attachment 253139 [details] [review]: ++
Hey Marco, I'm happy to commit these if you rebase them and verify that they still work properly. Not sure if you're still interested in working on Empathy after three years, though. :(
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/731.