After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706662 - Launch g-c-c instead of empathy-accounts
Launch g-c-c instead of empathy-accounts
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Marco Barisione
empathy-maint
Depends on: 706648
Blocks:
 
 
Reported: 2013-08-23 13:29 UTC by Marco Barisione
Modified: 2018-05-22 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
accounts-dialog: make the UOA code more generic so we can use it for GOA (5.75 KB, patch)
2013-08-26 14:06 UTC, Marco Barisione
accepted-commit_now Details | Review
accounts-dialog: open gnome-control-center for accounts if available (5.32 KB, patch)
2013-08-26 14:06 UTC, Marco Barisione
accepted-commit_now Details | Review
accounts-dialog: open g-c-c properly in make use_external_storage_provider() (1.60 KB, patch)
2013-08-26 14:06 UTC, Marco Barisione
accepted-commit_now Details | Review

Description Marco Barisione 2013-08-23 13:29:56 UTC
With #706148 and #696267 fixed, gnome-control-center can now handle Telepathy accounts too.
This means that Empathy should open g-c-c instead of opening empathy-accounts to avoid some duplicated UI. g-c-c can be opened with D-Bus and we will be able to display a specific account when #706648 will be merged.

empathy-accounts is still fully functional and doesn't depend on g-c-c or GOA.
What should we do with it? I think that, if we remove it completely, users of other desktops (XFCE and KDE) could be annoyed. Ubuntu is not a concern as they use UOA anyway.
Some options are:
1) Just throw it away
2) Try to open g-c-c, if it's not activated open empathy-accounts
3) Open g-c-c if running under Gnome (I guess that is some environment variable we can rely on), empathy-accounts otherwise
Comment 1 Chandni Verma 2013-08-23 14:08:21 UTC
Throwing it away completely cannot be an option. It should always be the last most thing to fallback on. I guess I'll give my vote to option 3.
Comment 2 Guillaume Desmottes 2013-08-26 07:57:57 UTC
I'd say 2) if it's fast enough (ie: we don't have to wait for a D-Bus timeout) or 3).
Comment 3 Marco Barisione 2013-08-26 14:06:25 UTC
Created attachment 253137 [details] [review]
accounts-dialog: make the UOA code more generic so we can use it for GOA
Comment 4 Marco Barisione 2013-08-26 14:06:29 UTC
Created attachment 253138 [details] [review]
accounts-dialog: open gnome-control-center for accounts if available
Comment 5 Marco Barisione 2013-08-26 14:06:33 UTC
Created attachment 253139 [details] [review]
accounts-dialog: open g-c-c properly in make use_external_storage_provider()

By using the D-Bus interface of gnome-control-center we can open the
panel on a specific account.
Comment 6 Marco Barisione 2013-08-26 14:07:52 UTC
(In reply to comment #2)
> I'd say 2) if it's fast enough (ie: we don't have to wait for a D-Bus timeout)
> or 3).

It fails immediately if it cannot be activated.
Comment 7 Guillaume Desmottes 2013-08-27 12:09:20 UTC
Review of attachment 253137 [details] [review]:

++
Comment 8 Guillaume Desmottes 2013-08-27 12:11:38 UTC
Review of attachment 253138 [details] [review]:

++
Comment 9 Guillaume Desmottes 2013-08-27 12:12:14 UTC
Review of attachment 253139 [details] [review]:

++
Comment 10 Michael Catanzaro 2016-07-22 01:59:00 UTC
Hey Marco, I'm happy to commit these if you rebase them and verify that they still work properly. Not sure if you're still interested in working on Empathy after three years, though. :(
Comment 11 GNOME Infrastructure Team 2018-05-22 16:17:41 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/731.