After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706653 - Need to escape markup for place description
Need to escape markup for place description
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks: 706724
 
 
Reported: 2013-08-23 12:15 UTC by Jonas Danielsson
Modified: 2013-08-29 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MainWindow: escape markup for place description (991 bytes, patch)
2013-08-23 12:16 UTC, Jonas Danielsson 		accepted-commit_now Details | Review
MainWindow: escape markup for place description v2 (1.41 KB, patch)
2013-08-28 13:17 UTC, Jonas Danielsson 		committed Details | Review

Description Jonas Danielsson 2013-08-23 12:15:46 UTC 
It is possible to get search results that include characters like '&'.
We need to escape the markup sent to the search result treeview.

Otherwise we end up with warnings in the console like:
"(gnome-maps:2368): Gtk-WARNING **: Failed to set text from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity - escape ampersand as &"
Comment 1 Jonas Danielsson 2013-08-23 12:16:32 UTC 
Created attachment 252840 [details] [review]
MainWindow: escape markup for place description
Comment 2 Zeeshan Ali 2013-08-23 12:39:02 UTC 
Review of attachment 252840 [details] [review]:

Good stuff but I'd prefer if you add the description of the bug to commit log (The more details in the log, the better).
Comment 3 Jonas Danielsson 2013-08-28 13:17:28 UTC 
Created attachment 253378 [details] [review]
MainWindow: escape markup for place description v2

Sure, updated commit log.
Comment 4 Zeeshan Ali 2013-08-28 13:43:22 UTC 
Review of attachment 253378 [details] [review]:

The limit for commit log description section is 74 columns, its 50 for shortlog only.

ACK with or w/o this change.
Comment 5 Jonas Danielsson 2013-08-29 06:47:21 UTC 
Review of attachment 253378 [details] [review]:

Commited with update to description section
Comment 6 Zeeshan Ali 2013-08-29 12:19:24 UTC 
(In reply to comment #5)
> Review of attachment 253378 [details] [review]:
> 
> Commited with update to description section

If you have git-bz setup, please do use `git bz push` instead of `git push` so you can update the bug and patch statuses easily at the same time. :)