After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706635 - Add gsetting for max-search-results
Add gsetting for max-search-results
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks: 706636 706715
 
 
Reported: 2013-08-23 08:18 UTC by Jonas Danielsson
Modified: 2013-08-27 23:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add new gsetting max-search-results (2.74 KB, patch)
2013-08-23 08:19 UTC, Jonas Danielsson 		needs-work Details | Review
Add new gsetting max-search-results v2 (1.95 KB, patch)
2013-08-23 12:53 UTC, Jonas Danielsson 		committed Details | Review

Description Jonas Danielsson 2013-08-23 08:18:01 UTC 
Right now we don't set answer_count on our GeocodeForward object before searching, resulting in a default value of 10.

Lets bump this to 25 and add a gsetting for it.
Comment 1 Jonas Danielsson 2013-08-23 08:19:10 UTC 
Created attachment 252815 [details] [review]
Add new gsetting max-search-results
Comment 2 Zeeshan Ali 2013-08-23 12:43:29 UTC 
Review of attachment 252815 [details] [review]:

::: data/org.gnome.maps.gschema.xml.in
@@ +27,3 @@
     </key>
+    <key name="max-search-results" type="i">
+      <default>25</default>

With scrolled window in place, we only need this to not overwelm the resources or get maps stuck so we want a much larger value here, e.g 100?

::: src/mapView.js
@@ +54,3 @@
     Extends: GtkChamplain.Embed,
 
+    _init: function(overlay, answerCount) {

I mapView itself should fetch the answerCount from gsetting.
Comment 3 Jonas Danielsson 2013-08-23 12:53:09 UTC 
Created attachment 252845 [details] [review]
Add new gsetting max-search-results v2
Comment 4 Zeeshan Ali 2013-08-23 14:07:04 UTC 
Review of attachment 252845 [details] [review]:

ACK though I'd want it to be pushed after bug#706636.
Comment 5 Zeeshan Ali 2013-08-27 23:22:31 UTC 
(In reply to comment #4)
> Review of attachment 252845 [details] [review]:
> 
> ACK though I'd want it to be pushed after bug#706636.

I meant, at the same time. :)