After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706607 - loginDialog: add support for auth without username / fix Not Listed?
loginDialog: add support for auth without username / fix Not Listed?
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-22 19:17 UTC by Ray Strode [halfline]
Modified: 2013-08-23 15:41 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
loginDialog: add support for auth without username / fix Not Listed? (5.25 KB, patch)
2013-08-22 19:17 UTC, Ray Strode [halfline] 		committed Details | Review
loginDialog: ask for username up front if disable-user-list==TRUE (5.28 KB, patch)
2013-08-22 20:25 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2013-08-22 19:17:22 UTC 
commit 93f072d1fcf578c4e7550bd755e84bd46abcd493 attempted to
add support for auth without a username to the login screen, but
do to a messed up rebase only partially added it.

This commit fixes that.
Comment 1 Ray Strode [halfline] 2013-08-22 19:17:24 UTC 
Created attachment 252787 [details] [review]
loginDialog: add support for auth without username / fix Not Listed?
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-22 19:30:33 UTC 
Review of attachment 252787 [details] [review]:

::: js/gdm/loginDialog.js
@@ +592,3 @@
         this._user = null;
 
+        if (beginRequest == AuthPrompt.BeginRequestType.PROVIDE_USERNAME) {

if (beginRequest == AuthPrompt.BeginRequestType.PROVIDE_USERNAME && !this._disableUserList)
    this._showUserList();
else
    this._hideUserListAndBeginVerification();
Comment 3 Ray Strode [halfline] 2013-08-22 19:41:09 UTC 
(pushed with that change)
Attachment 252787 [details] pushed as 5f9e501 - loginDialog: add support for auth without username / fix Not Listed?
Comment 4 Ray Strode [halfline] 2013-08-22 20:12:01 UTC 
Actually this still isn't quite right.  I mean it will work, but it means gnome-shell won't have any notion of who the user is when disable-user-list is TRUE since it's not the one asking for a username.
Comment 5 Ray Strode [halfline] 2013-08-22 20:25:56 UTC 
Created attachment 252794 [details] [review]
loginDialog: ask for username up front if disable-user-list==TRUE

Right now, we rely on PAM to ask for the username if disable-user-list
is TRUE.  This is suboptimal because it means we can't check if we
should show a session menu.

This commit changes disable-user-list==TRUE to ask for a username up
front, rather than have PAM do it.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-08-22 20:27:02 UTC 
Review of attachment 252794 [details] [review]:

OK.
Comment 7 Ray Strode [halfline] 2013-08-23 15:40:59 UTC 
Attachment 252794 [details] pushed as 44e3811 - loginDialog: ask for username up front if disable-user-list==TRUE