After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706600 - basetransform: Don't push out identical caps
basetransform: Don't push out identical caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.1.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-22 17:06 UTC by Edward Hervey
Modified: 2013-08-23 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basetransform: Don't push out identical caps (1.64 KB, patch)
2013-08-22 17:06 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2013-08-22 17:06:39 UTC
This avoids triggering plenty of extra code/methods/overhead downstream when
we can just quickly check whenever we want to set caps whether they are
identical or not
Comment 1 Edward Hervey 2013-08-22 17:06:48 UTC
Created attachment 252775 [details] [review]
basetransform: Don't push out identical caps
Comment 2 Sebastian Dröge (slomo) 2013-08-23 08:08:15 UTC
Review of attachment 252775 [details] [review]:

Looks good obviously, but maybe we just want to put that somewhere in gstpad.c instead? :)
Comment 3 Wim Taymans 2013-08-23 08:41:30 UTC
There is a similar thing in base videoencoder
Comment 4 Sebastian Dröge (slomo) 2013-08-23 08:53:45 UTC
Yes, and the other audio/video codec base classes
Comment 5 Edward Hervey 2013-08-23 11:06:42 UTC
The reason why I didn't put it in gstpad is that the check should only be done for elements that create new caps (or push existing ones several times).

Doing it in gstpad would have created too much of an overhead. Better fix the issue at the source.

I also have similar patches for the various audio/video base classes, just wanted to know what people thought about it first.
Comment 6 Sebastian Dröge (slomo) 2013-08-23 11:29:32 UTC
Ok, then go ahead
Comment 7 Edward Hervey 2013-08-23 13:24:09 UTC
commit 307d67f8c067d202fbb01ed5f3d930cea3de67d0
Author: Edward Hervey <edward@collabora.com>
Date:   Thu Aug 22 19:01:32 2013 +0200

    basetransform: Don't push out identical caps
    
    This avoids triggering plenty of extra code/methods/overhead downstream when
    we can just quickly check whenever we want to set caps whether they are
    identical or not
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706600

commit d1cf4b2b9a29cb1b0ea56b451c8cdf25580b31f0
Author: Edward Hervey <edward@collabora.com>
Date:   Fri Aug 23 15:22:43 2013 +0200

    videocoder: Don't push out identical caps
    
    This avoids triggering plenty of extra code/methods/overhead downstream when
    we can just quickly check whenever we want to set caps whether they are
    identical or not
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706600

commit cd3fe60c689ff0f679521f455f8a8e26ffbfda31
Author: Edward Hervey <edward@collabora.com>
Date:   Fri Aug 23 15:22:05 2013 +0200

    audiodecoder: Don't push out identical caps
    
    This avoids triggering plenty of extra code/methods/overhead downstream when
    we can just quickly check whenever we want to set caps whether they are
    identical or not
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706600