Created attachment 252775 [details] [review]
basetransform: Don't push out identical caps

Review of attachment 252775 [details] [review]:

Looks good obviously, but maybe we just want to put that somewhere in gstpad.c instead? :)

There is a similar thing in base videoencoder

Yes, and the other audio/video codec base classes

The reason why I didn't put it in gstpad is that the check should only be done for elements that create new caps (or push existing ones several times).

Doing it in gstpad would have created too much of an overhead. Better fix the issue at the source.

I also have similar patches for the various audio/video base classes, just wanted to know what people thought about it first.

Ok, then go ahead

commit 307d67f8c067d202fbb01ed5f3d930cea3de67d0
Author: Edward Hervey <edward@collabora.com>
Date:   Thu Aug 22 19:01:32 2013 +0200

    basetransform: Don't push out identical caps
    
    This avoids triggering plenty of extra code/methods/overhead downstream when
    we can just quickly check whenever we want to set caps whether they are
    identical or not
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706600

commit d1cf4b2b9a29cb1b0ea56b451c8cdf25580b31f0
Author: Edward Hervey <edward@collabora.com>
Date:   Fri Aug 23 15:22:43 2013 +0200

    videocoder: Don't push out identical caps
    
    This avoids triggering plenty of extra code/methods/overhead downstream when
    we can just quickly check whenever we want to set caps whether they are
    identical or not
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706600

commit cd3fe60c689ff0f679521f455f8a8e26ffbfda31
Author: Edward Hervey <edward@collabora.com>
Date:   Fri Aug 23 15:22:05 2013 +0200

    audiodecoder: Don't push out identical caps
    
    This avoids triggering plenty of extra code/methods/overhead downstream when
    we can just quickly check whenever we want to set caps whether they are
    identical or not
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706600