After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706571 - HeaderBars - close button picks up hover style from WM theme
HeaderBars - close button picks up hover style from WM theme
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-08-22 10:44 UTC by Allan Day
Modified: 2013-08-22 15:50 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10

Attachments
csd: fix hover for dark theme (2.56 KB, patch)
2013-08-22 15:49 UTC, Jakub Steiner 		accepted-commit_now Details | Review

Description Allan Day 2013-08-22 10:44:14 UTC 
Adwaita was recently updated to give a new visual style to window manager controls (see bug 706321). The problem is that close buttons in HeaderBars seem to be picking up the new hover style, meaning that unwanted styling appears. This results in a harsh white border and an expansion of the HeaderBar close button that shifts other controls to the left.
Comment 1 Allan Day 2013-08-22 15:25:46 UTC 
Seems like some of this is fixed. The movement issue has been resolved and the light theme looks fine.

The close button still gets a light highlight effect on hover though.
Comment 2 Allan Day 2013-08-22 15:26:35 UTC 
Those fixes might have come from: https://git.gnome.org/browse/gtk+/commit/?id=22378bbab56e49d9948e1ec2122bb6737f1543cc
Comment 3 Jakub Steiner 2013-08-22 15:49:00 UTC 
Created attachment 252770 [details] [review]
csd: fix hover for dark theme

- use the existing style separation too - borders
  are defined separately from fills.
Comment 4 Jakub Steiner 2013-08-22 15:50:24 UTC 
Attachment 252770 [details] pushed as 35831d6 - csd: fix hover for dark theme
Comment 5 Cosimo Cecchi 2013-08-22 15:50:42 UTC 
Review of attachment 252770 [details] [review]:

Looks good