After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706562 - DOAP name property should not be used for repository name
DOAP name property should not be used for repository name
Status: RESOLVED FIXED
Product: sysadmin
Classification: Infrastructure
Component: Git
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
Depends on:
Blocks:
 
 
Reported: 2013-08-22 09:32 UTC by David King
Modified: 2013-08-22 10:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
only use the name property as a description fallback (1.93 KB, patch)
2013-08-22 09:32 UTC, David King
none Details | Review

Description David King 2013-08-22 09:32:17 UTC
Created attachment 252708 [details] [review]
only use the name property as a description fallback

The DOAP name property is the name of the project:

https://github.com/edumbill/doap/blob/master/schema/doap.rdf

The github mirror script uses the name property as the repository name, which causes problems when the name property does not match the repository name (which is perfectly legitimate). This can be avoided by using the repository property in the DOAP file:

<repository>
  <GitRepository>
    <location rdf:resource="git://git.gnome.org/cheese" />
    <browse rdf:resource="https://git.gnome.org/browse/cheese/" />
  </GitRepository>
</repository>

or by using the (already known) repository name directly in the mirror script. Attached is a patch which uses the repository name that is already known, and only uses the name property as a fallback for the github repository description. I have not tested the patch, and I do not known Python well, so please let me know if any changes are needed.
Comment 1 Olav Vitters 2013-08-22 09:49:57 UTC
That GitRepository is what all the other scripts use. See https://git.gnome.org/repositories.doap
Comment 2 Andrea Veri 2013-08-22 10:10:42 UTC
Hi David,

this looks sane to me, I've just tested your patch and everything seems to work as expected. It's actually simpler and easier to just look for the directory itself as found in the /git tree instead of parsing another doap file.

Thanks for working on it!