GNOME Bugzilla – Bug 706548
admin: notify detected bootloader configuration
Last modified: 2013-08-22 11:39:09 UTC
OSTree now supports multiple bootloader backends so notify which bootloader configuration was detected.
Created attachment 252689 [details] [review] admin: notify detected bootloader configuration
Created attachment 252691 [details] [review] [PATCH v2 1/1] admin: notify detected bootloader configuration Changes since v1: - Fix coding style trivial issues.
Created attachment 252714 [details] [review] admin: Add API to OtBootloader to get name How about these patches? I'd like to remove g_print() calls from what I consider the "library" code...I know it's a mess right now but this gets us farther in the right direction.
Created attachment 252715 [details] [review] admin: notify detected bootloader configuration OSTree now supports multiple bootloader backends so notify which bootloader configuration was detected. https://bugzilla.gnome.org/show_bug.cgi?id=706548 Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
(In reply to comment #3) > Created an attachment (id=252714) [details] [review] > admin: Add API to OtBootloader to get name > > How about these patches? I'd like to remove g_print() calls from what > I consider the "library" code...I know it's a mess right now but this > gets us farther in the right direction. Agreed, it is much better with your patches. Also, I wonder if this is really a candidate for g_print() or if it should be a g_message(). In fact, sometimes I feel that the ostree admin operations are too verbose. For example, I don't know if is worth to tell the user that boot/syslinux/syslinux.cfg has been saved since the path is fixed anyways. I would like to identify when g_{debug,message,warning} can be used instead of g_print() so the user can change the log level.
(In reply to comment #5) > Agreed, it is much better with your patches. Also, I wonder if this is really a > candidate for g_print() or if it should be a g_message(). In fact, sometimes I > feel that the ostree admin operations are too verbose. Totally agreed; honestly they're mostly leftover debugging prints...except that some information we still only have inside library calls that we *do* want to print. > I would like to identify when g_{debug,message,warning} can be used instead of > g_print() so the user can change the log level. Yeah. I'll make another patch to clean this up a bit.
Attachment 252714 [details] pushed as 000dd5a - admin: Add API to OtBootloader to get name Attachment 252715 [details] pushed as 695621d - admin: notify detected bootloader configuration