After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706548 - admin: notify detected bootloader configuration
admin: notify detected bootloader configuration
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-22 02:13 UTC by Javier Martinez Canillas
Modified: 2013-08-22 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
admin: notify detected bootloader configuration (1.38 KB, patch)
2013-08-22 02:14 UTC, Javier Martinez Canillas
none Details | Review
[PATCH v2 1/1] admin: notify detected bootloader configuration (1.38 KB, patch)
2013-08-22 02:35 UTC, Javier Martinez Canillas
none Details | Review
admin: Add API to OtBootloader to get name (4.03 KB, patch)
2013-08-22 10:50 UTC, Colin Walters
committed Details | Review
admin: notify detected bootloader configuration (1.16 KB, patch)
2013-08-22 10:51 UTC, Colin Walters
committed Details | Review

Description Javier Martinez Canillas 2013-08-22 02:13:10 UTC
OSTree now supports multiple bootloader backends so
notify which bootloader configuration was detected.
Comment 1 Javier Martinez Canillas 2013-08-22 02:14:53 UTC
Created attachment 252689 [details] [review]
admin: notify detected bootloader configuration
Comment 2 Javier Martinez Canillas 2013-08-22 02:35:17 UTC
Created attachment 252691 [details] [review]
[PATCH v2 1/1] admin: notify detected bootloader configuration

Changes since v1:
 - Fix coding style trivial issues.
Comment 3 Colin Walters 2013-08-22 10:50:58 UTC
Created attachment 252714 [details] [review]
admin: Add API to OtBootloader to get name

How about these patches?  I'd like to remove g_print() calls from what
I consider the "library" code...I know it's a mess right now but this
gets us farther in the right direction.
Comment 4 Colin Walters 2013-08-22 10:51:45 UTC
Created attachment 252715 [details] [review]
admin: notify detected bootloader configuration

OSTree now supports multiple bootloader backends so
notify which bootloader configuration was detected.

https://bugzilla.gnome.org/show_bug.cgi?id=706548

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Comment 5 Javier Martinez Canillas 2013-08-22 11:32:23 UTC
(In reply to comment #3)
> Created an attachment (id=252714) [details] [review]
> admin: Add API to OtBootloader to get name
> 
> How about these patches?  I'd like to remove g_print() calls from what
> I consider the "library" code...I know it's a mess right now but this
> gets us farther in the right direction.

Agreed, it is much better with your patches. Also, I wonder if this is really a candidate for g_print() or if it should be a g_message(). In fact, sometimes I feel that the ostree admin operations are too verbose.

For example, I don't know if is worth to tell the user that boot/syslinux/syslinux.cfg has been saved since the path is fixed anyways.

I would like to identify when g_{debug,message,warning} can be used instead of g_print() so the user can change the log level.
Comment 6 Colin Walters 2013-08-22 11:36:56 UTC
(In reply to comment #5)

> Agreed, it is much better with your patches. Also, I wonder if this is really a
> candidate for g_print() or if it should be a g_message(). In fact, sometimes I
> feel that the ostree admin operations are too verbose.

Totally agreed; honestly they're mostly leftover debugging prints...except that some information we still only have inside library calls that we *do* want to print.

> I would like to identify when g_{debug,message,warning} can be used instead of
> g_print() so the user can change the log level.

Yeah.  I'll make another patch to clean this up a bit.
Comment 7 Colin Walters 2013-08-22 11:38:44 UTC
Attachment 252714 [details] pushed as 000dd5a - admin: Add API to OtBootloader to get name
Attachment 252715 [details] pushed as 695621d - admin: notify detected bootloader configuration