After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706543 - evdev: use monotonic times for the events
evdev: use monotonic times for the events
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-21 22:20 UTC by Giovanni Campagna
Modified: 2013-09-09 10:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
evdev: use monotonic times for the events (1.52 KB, patch)
2013-08-21 22:20 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-08-21 22:20:27 UTC 
The monotonic clock is what X uses too, so this way the timestamps
can be compared.
Comment 1 Giovanni Campagna 2013-08-21 22:20:30 UTC 
Created attachment 252679 [details] [review]
evdev: use monotonic times for the events
Comment 2 Emmanuele Bassi (:ebassi) 2013-09-09 09:52:56 UTC 
Review of attachment 252679 [details] [review]:

looks generally okay to me, just a minor coding style fix before commit.

::: clutter/evdev/clutter-device-manager-evdev.c
@@ +592,3 @@
+  /* Tell evdev to use the monotonic clock for its timestamps */
+  clkid = CLOCK_MONOTONIC;
+  ioctl(fd, EVIOCSCLOCKID, &clkid);

missing space.
Comment 3 Giovanni Campagna 2013-09-09 10:07:15 UTC 
Attachment 252679 [details] pushed as b73f513 - evdev: use monotonic times for the events