After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706542 - some follow up smartcard fixes
some follow up smartcard fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-21 22:08 UTC by Ray Strode [halfline]
Modified: 2013-08-22 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
objectManager: clear inhibitor on unregistered interfaces (3.38 KB, patch)
2013-08-21 22:08 UTC, Ray Strode [halfline]
committed Details | Review
gdmUtil: make _startService support no username (5.14 KB, patch)
2013-08-21 22:08 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2013-08-21 22:08:22 UTC
I've been doing some follow up testing of the smartcard stuff and hit a
couple of bugs that fell out from the last round of the adjustments.
Comment 1 Ray Strode [halfline] 2013-08-21 22:08:24 UTC
Created attachment 252677 [details] [review]
objectManager: clear inhibitor on unregistered interfaces

A D-Bus service can export more supported interfaces than the
shell cares about.  In those cases, we avoid creating proxies,
but neglect to finish things up so the object manager class
knows it can mark itself loaded.

This commit makes sure we do the proper finishing, so the object
manager still loads in the face of unsupported interfaces.
Comment 2 Ray Strode [halfline] 2013-08-21 22:08:27 UTC
Created attachment 252678 [details] [review]
gdmUtil: make _startService support no username

commit fd11ad95f61b904d6f7014f8d56c1c27d88af65c factored
out duplicated code, but unintentionally dropped support
for beginning verification without a username.

This commit brings it back.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-08-21 22:31:32 UTC
Review of attachment 252678 [details] [review]:

::: js/gdm/util.js
@@ +407,3 @@
+                   return;
+               } catch(e) {
+                   this._reportInitError('Failed to start verification for user', e);

"for user"?
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-08-21 22:31:55 UTC
Review of attachment 252677 [details] [review]:

OK.

::: js/misc/objectManager.js
@@ +73,2 @@
     _addInterface: function(objectPath, interfaceName, onFinished) {
            let info = this._interfaceInfos[interfaceName];

Seems the indentation is also off here; followup commit?
Comment 5 Ray Strode [halfline] 2013-08-22 13:41:28 UTC
Attachment 252677 [details] pushed as d29b86b - objectManager: clear inhibitor on unregistered interfaces
Attachment 252678 [details] pushed as 9720301 - gdmUtil: make _startService support no username
Comment 6 Ray Strode [halfline] 2013-08-22 13:44:47 UTC
(also pushed a separate indentation commit)