Bug 706510 – gst-launch-1.0 with empty pipeline crashes with Bison 3

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 706510 - gst-launch-1.0 with empty pipeline crashes with Bison 3


Summary:	gst-launch-1.0 with empty pipeline crashes with Bison 3


Status:	RESOLVED INCOMPLETE

Product:	GStreamer
Classification:	Platform
Component:	gstreamer (core)
Version:	git master
Hardware:	Other Linux

Importance:	Normal minor
Target Milestone:	NONE
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2013-08-21 15:35 UTC by Tim-Philipp Müller
Modified:	2013-12-22 22:37 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Tim-Philipp Müller 2013-08-21 15:35:33 UTC

+++ This bug was initially created as a clone of Bug #706462 +++

Apparently gst-launch-1.0 crashes with an empty pipeline and bison3, see comments and stack trace on other bug.

Comment 1 Kerrick Staley 2013-08-21 16:37:06 UTC

FWIW, I'm not seeing the behavior Bruce did:
$ ./tools/.libs/gst-launch-1.0
0:00:00.015440054 29732      0x1e9ad80 ERROR           GST_PIPELINE ./grammar.y:869:int priv_gst_parse_yyparse(void *, graph_t *): empty pipeline not allowed
ERROR: pipeline could not be constructed: empty pipeline not allowed.

This is on an up-to-date Arch Linux.

Bruce, the trace you posted to Bug #706462 is identical (modulo memory addresses) to the one you posted to Bug #705401. In both cases, yyscanner is NULL, which shouldn't happen with my patch. Can you please double-check that you tried the right patch?

Comment 2 Bruce Dubbs 2013-08-21 21:35:36 UTC

I edited the file with this sed:

sed -i  -e '/YYLEX_PARAM/d'                                       \
        -e '/parse-param.*scanner/i %lex-param { void *scanner }' \
    gst/parse/grammar.y

./configure --prefix=/usr         \
            --libexecdir=/usr/lib \
            --with-package-name="GStreamer 1.0.9 BLFS" \
            --with-package-origin="http://www.linuxfromscratch.org/blfs/view/svn/"

make
make check
sudo make install

Without the sed, the make errors out.

I am using gcc-4.8.1, glibc-2.18, binutils-2.23.2, bison-3.0.  I went ahead and installed in /usr.  

$ gst-launch-1.0 
Caught SIGSEGV accessing address 0x98

+ Trace 232405

#0 waitpid
from /lib/libpthread.so.0
#1 g_on_error_stack_trace
#2 fault_spin
at gst-launch.c line 139
#3 fault_handler_sigaction
#4 <signal handler called>
#5 priv_gst_parse_yylex
#6 priv_gst_parse_yyparse
#7 priv_gst_parse_launch
#8 gst_parse_launch_full
#9 gst_parse_launchv_full
#10 gst_parse_launchv
#11 main

Comment 3 Tim-Philipp Müller 2013-12-07 00:46:15 UTC

Is this still an issue with current git, after


commit 56d74ddb644052dc76d97c22b9f284cc0c7fe35a
Author: Fabian Kirsch <derFakir@web.de>
Date:   Tue Nov 19 15:03:35 2013 +0100

    parse: fix segfaulting prototype-mismatch
    
    Now YYDEBUG is always set, so check it's value
    
    https://bugzilla.gnome.org/show_bug.cgi?id=712679

Comment 4 Tim-Philipp Müller 2013-12-22 22:37:29 UTC

Going to assume it's fixed. Please re-open if this is not the case, thanks!

Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!