GNOME Bugzilla – Bug 706502
dlna: Update DBus signature after dleyna-renderer ABI fix
Last modified: 2013-09-02 14:05:23 UTC
dleyna-renderer has fixed some of its method and signal signatures to correctly mark object paths with the 'o' type instead of plain strings (see https://github.com/01org/dleyna-renderer/commit/3a225c3). Even if no proper code change would be needed as both 's' and 'o' are represented as gchar*, this unfortunately means that the generated DBus methods will fail to validate the incoming data. Since this is a new feature not yet part of any stable release and since Photos gracefully handles the validation error by disabling the feature on startup, no proper transition has been put in place and having a small flag day seemed an acceptable choice.
Created attachment 252556 [details] [review] dlna: Update DBus signature after dleyna-renderer ABI fix dleyna-renderer has fixed some of its method and signal signatures to correctly mark object paths with the 'o' type instead of plain strings (see https://github.com/01org/dleyna-renderer/commit/3a225c3). Even if no proper code change would be needed as both 's' and 'o' are represented as gchar*, this unfortunately means that the generated DBus methods will fail to validate the incoming data. Since this is a new feature not yet part of any stable release and since Photos gracefully handles the validation error by disabling the feature on startup, no proper transition has been put in place and having a small flag day seemed an acceptable choice.
Review of attachment 252556 [details] [review]: Looks good. However we can only commit this when a new dleyna-renderer release is available. Will we have one in time for GNOME 3.9.91 ?
An update release tarball should be uploaded to https://01.org/dleyna/downloads next week. I'll ping you as soon as it will get uploaded. Thanks!
Comment on attachment 252556 [details] [review] dlna: Update DBus signature after dleyna-renderer ABI fix A new dleyna-renderer has been released. Thanks!