After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706476 - empty spaces at the end of strings
empty spaces at the end of strings
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: UI
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-21 10:20 UTC by Dušan
Modified: 2013-08-27 23:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Dušan 2013-08-21 10:20:23 UTC 
Are needed this empty spaces at the end of strings?



#. "Last updated" precedes the note last updated date
#: ../src/bjb-note-view.c:228
msgid "Last updated "

#: ../src/bjb-empty-results-box.c:160
msgid "Oops, "
Comment 1 André Klapper 2013-08-21 12:00:33 UTC 
The latter one uses g_strconcat and should just die, or at least use proper language. For the first one I don't understand the comment line above it.

In general for developers:
https://wiki.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences
Comment 2 Pierre-Yves Luyten 2013-08-21 23:12:44 UTC 
About the split itself for "last updated": this is the mtime appearing on bottom of the note -
https://github.com/gnome-design-team/gnome-mockups/raw/master/notes/notes-wide.png

(btw Bijiben suffers from other bug related to this, see https://bugzilla.gnome.org/show_bug.cgi?id=689171)

So, it is not a sentence. Eventually I could remove the trailing whitespace and rather add some space before the note timestamp (and i suppose i should respect ltr / rtl, too).



I will fix the <msgid "Oops, ">  to provide to translators one single string without space. André, does "proper language" refers to the "oops" wording itself? Actually i borrowed this from design / apps but of course i am opened to improve things if useful.
Comment 3 Pierre-Yves Luyten 2013-08-27 23:39:24 UTC 
Last udpated : Too close to the release to discuss design here, but i pushed a quick fix for the trailing whitespace.

commit 2ec401e78c7a3e912d63b629f2385454beeffded



Error box : remove space and use GtkLabel markup in another place. This was not raised here but was wrong, too.

-  label = g_strconcat ("<b><span size=\"large\">", _("No Notes Found"), "</span></b>", NULL);

commit ee9b0d2228b4dcf7a670cc93e449a0503227cf49