After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706444 - Add Solarized themes (Dark and Light), Patch Included
Add Solarized themes (Dark and Light), Patch Included
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-20 21:17 UTC by Edoardo Maria Elidoro
Modified: 2014-02-05 12:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for Solarized Dark/Light (8.21 KB, patch)
2013-08-20 21:17 UTC, Edoardo Maria Elidoro
none Details | Review

Description Edoardo Maria Elidoro 2013-08-20 21:17:40 UTC
Created attachment 252475 [details] [review]
Patch for Solarized Dark/Light

Seeing that someone filed a bug against Mousepad in Xfce Bugzilla about this, I thought it would be nice to have the Solarized themes shipped by default from gtksourceview.
Comment 1 Matthew Brush 2013-08-21 00:36:03 UTC
+1, the Solarized themes are "must have" in any self-respecting editor :)

If this isn't wanted, I could look into adding to Mousepad but it feels weird since we try to stick to stock GtkSourceView themes and languages to keep things simple and also other GtkSourceView editors wouldn't benefit from this highly popular theme.

FWIW, I think the scheme in above patch comes from here:
https://github.com/craig552uk/solarized-gedit

And information about the design of the theme is here:
http://ethanschoonover.com/solarized
Comment 2 Paolo Borelli 2013-08-21 08:24:34 UTC
In general I do not want to grow a huge number of themes in gtksourceview itself (e.g. keep them < 10), however I am open to adding some of them if they match the following

 - they are very popular
 - some gtksourceview program plans to use them by default (e.g. medit uses the kate theme)

These themes seem to fit, so I am ok adding them
Comment 3 Matthew Brush 2013-08-22 03:33:04 UTC
I think Solarized themes would meet the first criteria, but at least in Mousepad, not the second one, although I would be extremely pleased to have these available by default to users.
Comment 4 Sébastien Wilmet 2014-02-05 12:18:31 UTC
Pushed to the master branch:
https://git.gnome.org/browse/gtksourceview/commit/?id=2f40636405defbd14ffe9ecc91f18af5c5c9dd3f

Thanks.