After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706398 - increased intensity ANSI code no longer working
increased intensity ANSI code no longer working
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-20 13:48 UTC by Pierre Ossman
Modified: 2013-09-26 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screen: Use NULL for bold colour when same-as-fg is used (1.63 KB, patch)
2013-09-26 18:04 UTC, Christian Persch
none Details | Review

Description Pierre Ossman 2013-08-20 13:48:18 UTC
With the upgrade to the latest Gnome, I unfortunately noticed a problem with gnome-terminal. I've been using \e[01m to easily see where the prompt is. Wikipedia describes this as:

"Bold or increased intensity"

Previously vte implemented this as "bold _and_ increased intensity". As my primary goal was the intensity, this was quite sufficient. The new version unfortunately only does bold, breaking my usage. :(

I can't really find an alternative plan here. AFAICT, no other escape code will give me a bright color that is agnostic as far as the current color. Since I use the same $PS1 with various terminals in various configurations, this is rather essential.

So please bring back the old behaviour. :)

(bug 616436 might be related)
Comment 1 Christian Persch 2013-09-14 12:42:32 UTC
Can you bisect vte to see where the change was?
Comment 2 Pierre Ossman 2013-09-14 14:46:05 UTC
Hmm... maybe the problem is in gnome-terminal rather than vte. I've gone back as far as 0.32.0 with vte, and I'm still not getting the old behaviour.
Comment 3 Christian Persch 2013-09-14 14:49:08 UTC
There's nothing that gnome-terminal could do to influence this.
Comment 4 Pierre Ossman 2013-09-26 16:36:11 UTC
It appears there is, as I found the offending change. :)

Commit 84099c36 in gnome-terminal changed things so that vte_terminal_set_color_bold_rgba() started getting called no matter what. And the logic in gnome-terminal to set the default bold colour differs from the logic in vte. Commenting out that call in gnome-terminal restores the previous behaviour.
Comment 5 Christian Persch 2013-09-26 18:04:45 UTC
Created attachment 255864 [details] [review]
screen: Use NULL for bold colour when same-as-fg is used

Can you try this patch please?
Comment 6 Pierre Ossman 2013-09-26 19:58:28 UTC
Seems to do the trick. :)