GNOME Bugzilla – Bug 706378
ON/OFF button looks insensitive, but is actually sensitive
Last modified: 2013-08-29 15:43:53 UTC
Created attachment 252368 [details] screencast Looks like you're unable to modify it, but you actually can.
The issue here is that the NTP switch is insensitive (OSTree doesn't ship an NTP client) but it's possible to bypass it by clicking it on the row containing the switch. I think we're currently doing the wrong thing by setting the switch insensitive; should simply hide the option when the service isn't available. If the system integrator has chosen to not ship NTP, we shouldn't show an insensitive switch either.
Created attachment 253019 [details] [review] datetime: Hide the NTP switch when the service is unavailable
Can't we just have a hard dependency on a NTP client? Why doesn't OSTree have one?
OSTree has a fairly small core and doesn't ship many optional packages. I'm adding Walters to CC -- would an NTP client be something that OSTree can include? Regarding making an NTP client a hard dependency, I don't think this can work. We only use it through the systemd DBus interface at runtime and can't make it a hard compile time dependency. I could add a g_warning there though to let system integrators know that they're missing a dependency.
I'd be happy if it was an optional dependency; basically I think gnome-ostree is already a bit too large with not enough tests, and its entire purpose in life is to be a small well tested and validated core that can be reused by larger systems. Futher, gnome-ostree is only targeting virtualized environments, and what you really want there is to use paravirtualized devices like e.g.: http://www.linux-kvm.org/page/KVMClock
Review of attachment 253019 [details] [review]: Thanks Colin. Looks good to me, then.
Attachment 253019 [details] pushed as ab1d1b0 - datetime: Hide the NTP switch when the service is unavailable