After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706367 - clutter 1.15.90 fails to build against cogl 1.15.6
clutter 1.15.90 fails to build against cogl 1.15.6
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
1.15.x
Other Windows
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-20 08:36 UTC by Dominique Leuenberger
Modified: 2013-08-20 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dominique Leuenberger 2013-08-20 08:36:11 UTC
Clutter 1.15.90 and cogl 1.15.6 (both just released) do not work nicely together:

[  234s] gcc -DHAVE_CONFIG_H -I. -I../../../clutter  -DG_DISABLE_SINGLE_INCLUDES -DCOGL_DISABLE_DEPRECATED -DCOGL_DISABLE_DEPRECATION_WARNINGS -DCLUTTER_DISABLE_DEPRECATION_WARNINGS -DTESTS_DATA_DIR=\""../../../tests/data/"\" -I../../../ -I../../../ -I../../../clutter -I../../../clutter   -pthread -I/usr/include/atk-1.0 -I/usr/include/cogl -I/usr/include/json-glib-1.0 -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  -pthread -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2   -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  -fomit-frame-pointer -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -g -c textures-crossfade-cogl.c
[  235s] events-pointer-motion-scribbler.c:12:3: error: unknown type name 'CoglPath'
[  235s]    CoglPath    *cogl_path;
[  235s]    ^
[  235s] events-pointer-motion-scribbler.c: In function '_convert_clutter_path_node_to_cogl_path':
[  235s] events-pointer-motion-scribbler.c:27:7: warning: implicit declaration of function 'cogl_path_move_to' [-Wimplicit-function-declaration]
[  235s]        cogl_path_move_to (knot.x, knot.y);
[  235s]        ^


CoglPath was split out in cogl.

The fix can be to either include the appropriate cogl-path headers from within clutter or maybe the intention was for cogl to include them directly?
Comment 1 Emmanuele Bassi (:ebassi) 2013-08-20 09:55:28 UTC
thanks, should be fixed with this commit:

commit b6fc4a810f2f3437d5478241a6e6ff2aa43cf0b4
Author: Emmanuele Bassi <ebassi@gnome.org>
Date:   Tue Aug 20 10:52:37 2013 +0100

    Depend on the cogl-path-1.0 pkg-config file

    The CoglPath API has been split from the main Cogl SO, and we need to
    add it as a dependency.

    https://bugzilla.gnome.org/show_bug.cgi?id=706367
Comment 2 Dominique Leuenberger 2013-08-20 09:57:59 UTC
Thanks...

(please don't forget to push :) )
Comment 3 Dominique Leuenberger 2013-08-20 10:15:55 UTC
found the push: it's only in the clutter-1.16 branch, not in master.. that's what dripped me.

Just creating a test build now.
Comment 4 Emmanuele Bassi (:ebassi) 2013-08-20 10:43:18 UTC
actually, I had to revert the commit: Cogl is not supposed to break API/ABI, but there has been a bug in the inclusion guards, so Clutter builds fine, but everything else that uses Clutter is breaking.

the Cogl maintainers are fixing this as we speak.
Comment 5 Dominique Leuenberger 2013-08-20 10:51:15 UTC
(In reply to comment #4)
> actually, I had to revert the commit: Cogl is not supposed to break API/ABI,
> but there has been a bug in the inclusion guards, so Clutter builds fine, but
> everything else that uses Clutter is breaking.

That's not what I see: the build failure pasted in comment #0 is a build failure from clutter;
Comment 6 Emmanuele Bassi (:ebassi) 2013-08-20 11:02:05 UTC
yes, it fails in Clutter's cookbook examples, which use the public Clutter header - see above, re: "everything else that uses Clutter is breaking".
Comment 7 Dominique Leuenberger 2013-08-20 11:04:20 UTC
oh(In reply to comment #6)
> yes, it fails in Clutter's cookbook examples, which use the public Clutter
> header - see above, re: "everything else that uses Clutter is breaking".

oh :) now I understand.

well, with the latest patch in cogl, I'm afraid, 'everything using clutter' might build, but clutter does not:

make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/clutter-1.15.90/clutter'
  CC       clutter-x11-texture-pixmap.lo
In file included from ../clutter/clutter.h:85:0,
                 from ./x11/clutter-x11-texture-pixmap.h:31,
                 from ./x11/clutter-x11-texture-pixmap.c:48:
../clutter/clutter-paint-node.h:72:74: error: unknown type name 'CoglPath'
                                                                          CoglPath              *path);
                                                                          ^
make[2]: *** [clutter-x11-texture-pixmap.lo] Error 1