GNOME Bugzilla – Bug 706338
Also copy disabled features when copying message
Last modified: 2013-08-26 15:38:53 UTC
Created attachment 252298 [details] [review]
When copying a message in soup_cache_generate_conditional_request the orig message disabled features are not copied. The attached patch should fix this issue.
What problem were you running into exactly? I'm wondering if we should
be copying other fields too (flags, auth, etc)...
I don't remember exactly the use case here. The issue happened when trying to fix https://bugs.webkit.org/show_bug.cgi?id=115354 where we disabled the SOUP_TYPE_CONTENT_DECODER feature but the message that was actually sent had the feature enabled (it was enabled in the session). This patch fixed the issue, but now that you mentioned about the other fields I believe we should probably have a soup_message_copy method or something similar and use it when copying messages.