After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706338 - Also copy disabled features when copying message
Also copy disabled features when copying message
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2013-08-19 21:30 UTC by Andre Moreira Magalhaes
Modified: 2013-08-26 15:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.45 KB, patch)
2013-08-19 21:30 UTC, Andre Moreira Magalhaes 		committed Details | Review

Description Andre Moreira Magalhaes 2013-08-19 21:30:10 UTC 
Created attachment 252298 [details] [review]
Patch

When copying a message in soup_cache_generate_conditional_request the orig message disabled features are not copied. The attached patch should fix this issue.
Comment 1 Dan Winship 2013-08-25 13:08:11 UTC 
pushed.

What problem were you running into exactly? I'm wondering if we should
be copying other fields too (flags, auth, etc)...
Comment 2 Andre Moreira Magalhaes 2013-08-26 15:38:53 UTC 
I don't remember exactly the use case here. The issue happened when trying to fix https://bugs.webkit.org/show_bug.cgi?id=115354 where we disabled the SOUP_TYPE_CONTENT_DECODER feature but the message that was actually sent had the feature enabled (it was enabled in the session). This patch fixed the issue, but now that you mentioned about the other fields I believe we should probably have a soup_message_copy method or something similar and use it when copying messages.