GNOME Bugzilla – Bug 706300
Do not use GtkComboBox for search.
Last modified: 2013-08-20 12:18:58 UTC
Zeeshan Ali had some comments when adding the current way of searching: "[...] Don't think we want a combobox here. For searches, we still want to use a search entry and search results/suggestions shown appear in an overlay popup as shown in mockup: https://wiki.gnome.org/Design/Apps/Maps?action=AttachFile&do=get&target=Maps.png The main issue I see the combobox' drop down, using that for 'execute search' seems very odd from UX POV."
Created attachment 252370 [details] [review] Add search popup and use it to show search results This patch tries to follow the mockups of displaying the search results closer.
I have never before seen such a ui element anywhere else, so I'm not sure how it's supposed to work exactly. I agree that it the search is a bit odd today, mainly because we can't autocomplete correctly due to technical limitations, but apart from that the current combobox isn't much different from Firefox awesomebar or the combobox in Google Maps (web version).
Created attachment 252381 [details] [review] Add search popup and use it to show search results V2 Bugfix events.get_coords returns [bool, x, y] not [x, y] which made it all _almost_ work. :)
Review of attachment 252381 [details] [review]: Really good stuff man! That was very quick. I'll spare you the nitpicks to get this in for the release. :)
Pushing this now as its already a big improvement IMHO and more closer to mockup. Also to get this in release I'm going to roll out soon.
uh, ok.