Created attachment 252182 [details] [review]
accept IPv6 address in VPN plugins

Commit d8e6065f634424b99a9e033144cfad3418c46159 introduced a regression in VPN plugins, in file src/vpn-manager/nm-vpn-connection.c (http://cgit.freedesktop.org/NetworkManager/NetworkManager/diff/src/vpn-manager/nm-vpn-connection.c?id=d8e6065f634424b99a9e033144cfad3418c46159):

@@ -1072,13 +1068,12 @@ nm_vpn_connection_ip6_config_get (DBusGProxy *proxy,
val = (GValue *) g_hash_table_lookup (config_hash, NM_VPN_PLUGIN_IP6_CONFIG_PREFIX);
if (val)
- nm_ip6_address_set_prefix (addr, g_value_get_uint (val));
+ address.plen = g_value_get_uint (val);
- if (nm_ip6_address_get_address (addr) && nm_ip6_address_get_prefix (addr)) {
- nm_ip6_config_take_address (config, addr);
- } else {
+ if (IN6_IS_ADDR_UNSPECIFIED (&address.address) && address.plen)
+ nm_ip6_config_add_address (config, &address);
+ else {
nm_log_err (LOGD_VPN, "invalid IP6 config received!");
- nm_ip6_address_unref (addr);
g_object_unref (config);
nm_vpn_connection_config_maybe_complete (connection, FALSE);
}

IN6_IS_ADDR_UNSPECIFIED (&address.address) is always FALSE for valid IPv6 addresses and therefore trigger the error "invalid IP6 config received!". To solve this bug, a ! should be added in the if condition.