After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706268 - Should initiate search when user starts typing
Should initiate search when user starts typing
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-18 20:23 UTC by Rui Matos
Modified: 2013-08-20 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: Use GDK_EVENT_* macros (2.00 KB, patch)
2013-08-19 22:19 UTC, Bastien Nocera 		committed Details | Review
shell: Start search when typing (773 bytes, patch)
2013-08-19 22:20 UTC, Bastien Nocera 		committed Details | Review
Feels strange to be taken away from a regular panel when I hit a (2.91 KB, patch)
2013-08-20 02:17 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-08-18 20:23:31 UTC 
When in the overview page, regardless of current widget focus, when the user starts typing we should initiate a search.
Comment 1 Bastien Nocera 2013-08-19 22:19:51 UTC 
Created attachment 252306 [details] [review]
shell: Use GDK_EVENT_* macros

Instead of TRUE/FALSE
Comment 2 Bastien Nocera 2013-08-19 22:20:18 UTC 
Created attachment 252307 [details] [review]
shell: Start search when typing
Comment 3 Bastien Nocera 2013-08-19 22:38:50 UTC 
Attachment 252306 [details] pushed as 65c0b26 - shell: Use GDK_EVENT_* macros
Attachment 252307 [details] pushed as 8c7efd5 - shell: Start search when typing
Comment 4 Rui Matos 2013-08-20 02:17:39 UTC 
Created attachment 252330 [details] [review]
Feels strange to be taken away from a regular panel when I hit a

key. How about this on top?
--
shell: Don't start search while on regular panels

... either by just typing or pressing ctrl+F or ctrl+S.
Comment 5 Rui Matos 2013-08-20 02:18:16 UTC 
Ugh, nice work there with git bz...
Comment 6 Bastien Nocera 2013-08-20 02:37:30 UTC 
Review of attachment 252330 [details] [review]:

Thanks for testing this better than I did :)

::: shell/cc-window.c
@@ +1222,3 @@
+
+  if ((overview || search) &&
+      gtk_search_bar_handle_event (GTK_SEARCH_BAR (self->priv->search_bar), (GdkEvent*) event) == GDK_EVENT_STOP)

I'd move this above the initial setting of retval, but looks good.