GNOME Bugzilla – Bug 706253
timezone map: new location marker
Last modified: 2013-08-24 18:35:24 UTC
The current location marker is a pin, with a large head and a thin needle. The head draws all visual attention and most people tend to miss the thin needle, mistaking the head as the actual location. Attaching patches to replace it with a new image by Andreas Nilsson, as discussed in #gnome-design today.
Created attachment 252137 [details] [review] datetime: Alignment fixes for the location marker on timezone map Make sure the marker is drawn pixel-aligned to avoid fuzziness, and ensure that it actually ends up in the visible area.
Created attachment 252138 [details] [review] datetime: New location marker image for the timezone map The image was drawn by Andreas Nilsson <anilsson@redhat.com>
Created attachment 252139 [details] [review] datetime: Use g_clear_object()
Created attachment 252140 [details] [review] datetime: Load the pin image resource in init(), instead of draw()
Review of attachment 252137 [details] [review]: sure
Review of attachment 252138 [details] [review]: There is no image in this commit ?!
Review of attachment 252139 [details] [review]: sure
Review of attachment 252140 [details] [review]: The subject line is too long, the body of the commit message is too short. Explain why this change is made
Review of attachment 252138 [details] [review]: The image is here in the patch, it's just Splinter not showing it for reasons unknown. diffstat: panels/datetime/cc-timezone-map.c | 2 +- panels/datetime/data/pin.png | Bin 561 -> 666 bytes 2 files changed, 1 insertion(+), 1 deletion(-)
Review of attachment 252138 [details] [review]: Yeah, splinter does that (at least now a days). :(
Created attachment 252230 [details] [review] datetime: Move pixbuf loading out of the draw signal handler This moves the timezone location marker image loading code to init() where most of other resources are loaded, making the draw callback smaller and easier to read. As a plus, it also avoids needless allocations during each time the map is drawn.
Review of attachment 252138 [details] [review]: Yeah, the patch itself looks good
Review of attachment 252230 [details] [review]: Looks fine
Thanks for the reviews! Attachment 252137 [details] pushed as be79efe - datetime: Alignment fixes for the location marker on timezone map Attachment 252138 [details] pushed as 2dfde24 - datetime: New location marker image for the timezone map Attachment 252139 [details] pushed as 6255839 - datetime: Use g_clear_object() Attachment 252230 [details] pushed as fd4df35 - datetime: Move pixbuf loading out of the draw signal handler
*** Bug 686354 has been marked as a duplicate of this bug. ***