After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706239 - Background in login history is different from all other lists
Background in login history is different from all other lists
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
git master
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-18 12:41 UTC by Andreas Nilsson
Modified: 2013-09-16 13:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (135.44 KB, image/png)
2013-08-18 12:41 UTC, Andreas Nilsson 		  Details
change background color (1.25 KB, patch)
2013-09-09 14:22 UTC, Ondrej Holy 		none Details | Review
port to GtkListBox (6.07 KB, patch)
2013-09-10 09:09 UTC, Ondrej Holy 		committed Details | Review
screenshot of ported dialog (19.74 KB, text/plain)
2013-09-10 09:10 UTC, Ondrej Holy 		  Details
screenshot of the ported dialog (19.74 KB, image/png)
2013-09-10 09:12 UTC, Ondrej Holy 		  Details

Description Andreas Nilsson 2013-08-18 12:41:05 UTC 
Created attachment 252109 [details]
screenshot

While the lists in most other places are white, this list is gray.
Comment 1 Andreas Nilsson 2013-08-18 12:41:36 UTC 
On top of that, it makes it look a bit inactive.
Comment 2 Ondrej Holy 2013-09-09 14:22:35 UTC 
Created attachment 254488 [details] [review]
change background color 

It used to be white as you can see at the screenshot at Bug 681772, something has to be changed...

Attached patch changed it's color hard, however it isn't probably the best idea due to the themes. Could you give me an example how to do that better?
Comment 3 Rui Matos 2013-09-09 16:11:26 UTC 
(In reply to comment #2)
> It used to be white as you can see at the screenshot at Bug 681772, something
> has to be changed...

That was probably before https://git.gnome.org/browse/gnome-themes-standard/commit/?id=a7406e56b1597ff2642a39d55433a719b0d6d477 .

> Attached patch changed it's color hard, however it isn't probably the best idea
> due to the themes. Could you give me an example how to do that better?

Other panels use either GtkTreeView or GtkListBox. This dialog should be ported to use GtkListBox too.
Comment 4 Ondrej Holy 2013-09-10 09:09:55 UTC 
Created attachment 254564 [details] [review]
port to GtkListBox

Thanks, it's really good point with porting to GtkListBox. So attached patch port the dialog to use GtkListBox.
Comment 5 Ondrej Holy 2013-09-10 09:10:30 UTC 
Created attachment 254566 [details]
screenshot of ported dialog
Comment 6 Ondrej Holy 2013-09-10 09:12:06 UTC 
Created attachment 254567 [details]
screenshot of the ported dialog
Comment 7 Rui Matos 2013-09-10 09:30:09 UTC 
Review of attachment 254564 [details] [review]:

Looks fine
Comment 8 Andreas Nilsson 2013-09-10 10:37:59 UTC 
(In reply to comment #6)
> Created an attachment (id=254567) [details]
> screenshot of the ported dialog

Looks excellent. Thanks!
Comment 9 Ondrej Holy 2013-09-16 12:58:27 UTC 
Comment on attachment 254564 [details] [review]
port to GtkListBox

commit 3f8d1ca21e2571d8afd871239a29dff81ff429de
Comment 10 Ondrej Holy 2013-09-16 13:25:42 UTC 
UI break request approval: 
https://mail.gnome.org/archives/release-team/2013-September/msg00091.html