After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706214 - libostree: Improve commit filter API
libostree: Improve commit filter API
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-17 18:20 UTC by Colin Walters
Modified: 2013-08-25 19:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libostree: Improve commit filter API (4.41 KB, patch)
2013-08-17 18:20 UTC, Colin Walters 		reviewed Details | Review
libostree: Improve commit filter API (5.37 KB, patch)
2013-08-25 19:23 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2013-08-17 18:20:01 UTC 
Make the structure private, and document the flags.
Comment 1 Colin Walters 2013-08-17 18:20:02 UTC 
Created attachment 252062 [details] [review]
libostree: Improve commit filter API
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-25 19:16:29 UTC 
Review of attachment 252062 [details] [review]:

::: src/libostree/ostree-repo.c
@@ +1539,3 @@
+
+  guint reserved_flags : 31;
+  guint skip_xattrs : 1;

Since this is private, do we really need reserved fields? Why not just store the flags directly instead of using bitfields?
Comment 3 Colin Walters 2013-08-25 19:23:55 UTC 
Created attachment 253071 [details] [review]
libostree: Improve commit filter API

Make the structure private, and document the flags.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-08-25 19:26:39 UTC 
Review of attachment 253071 [details] [review]:

OK.
Comment 5 Colin Walters 2013-08-25 19:30:58 UTC 
Attachment 253071 [details] pushed as 6c61b19 - libostree: Improve commit filter API