After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706188 - Ensure Extract button is a constant size
Ensure Extract button is a constant size
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-17 09:37 UTC by Phillip Wood
Modified: 2013-08-20 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ensure Extract button is a constant size (1.84 KB, patch)
2013-08-17 09:38 UTC, Phillip Wood 		reviewed Details | Review
Updated patch with 'use-underline' set for the fake buttons and the (1.96 KB, patch)
2013-08-20 13:08 UTC, Phillip Wood 		accepted-commit_now Details | Review
Updated patch, added missing GTK_BUTTON casts (1.99 KB, patch)
2013-08-20 14:27 UTC, Phillip Wood 		committed Details | Review

Description Phillip Wood 2013-08-17 09:37:25 UTC 
If the translation of 'Stop' was longer than that of 'Extract' the
extract button would change size when it was clicked. Fix by adding
fake buttons with both labels to a size group as for the play and
select all buttons.
Comment 1 Phillip Wood 2013-08-17 09:38:06 UTC 
Created attachment 251985 [details] [review]
Ensure Extract button is a constant size
Comment 2 Christophe Fergeau 2013-08-19 11:52:23 UTC 
Review of attachment 251985 [details] [review]:

::: src/sj-main.c
@@ +2160,3 @@
+    size_group = gtk_size_group_new (GTK_SIZE_GROUP_HORIZONTAL);
+
+    fake_button1 = gtk_button_new_with_label (_("Extract"));

As discussed in the stock items  bug, it would be better to have the underline so that the fake button exactly matches the actual one.

@@ +2166,3 @@
+                              fake_button1);
+
+    fake_button2 = gtk_button_new_with_label (_("Stop Extracting Now"));

I guess this is a leftover from your testing, the label that is currently used is "Stop"
Comment 3 Phillip Wood 2013-08-20 13:08:45 UTC 
Created attachment 252414 [details] [review]
Updated patch with 'use-underline' set for the fake buttons and the

stop label corrected - sorry I should have spotted that for myself
before I posted the first patch.
Comment 4 Christophe Fergeau 2013-08-20 13:18:00 UTC 
Comment on attachment 252414 [details] [review]
Updated patch with 'use-underline' set for the fake buttons and the

Looks good, now, thanks!
Comment 5 Phillip Wood 2013-08-20 14:27:16 UTC 
Created attachment 252432 [details] [review]
Updated patch, added missing GTK_BUTTON casts
Comment 6 Phillip Wood 2013-08-20 14:43:07 UTC 
Attachment 252432 [details] pushed as 013cb9e - Ensure Extract button is a constant size