After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706157 - Get rid of gom_filename_to_mime_type
Get rid of gom_filename_to_mime_type
Status: RESOLVED FIXED
Product: gnome-online-miners
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Miners maintainer(s)
GNOME Online Miners maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-16 18:23 UTC by Debarshi Ray
Modified: 2013-08-18 05:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
utils: Replace gom_filename_to_mime_type with g_content_type_guess (2.63 KB, patch)
2013-08-16 18:26 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-08-16 18:23:46 UTC 
I think a much better option is g_content_type_guess.

gom_filename_to_mime_type only works with PDFs, and is not useful for mining images (eg., the Flickr miner). So we end up using g_content_type_guess in those cases, anyway.
Comment 1 Debarshi Ray 2013-08-16 18:26:05 UTC 
Created attachment 251927 [details] [review]
utils: Replace gom_filename_to_mime_type with g_content_type_guess
Comment 2 Cosimo Cecchi 2013-08-17 08:44:13 UTC 
Review of attachment 251927 [details] [review]:

Okay